? Pending

User tests: Successful: Unsuccessful:

avatar hans2103
hans2103
16 Jan 2019

Pull Request for Issue # .

Summary of Changes

When you edit an article and press save as copy the hits counter is not reset. This PR adds a line of code to reset the hits of an article when you click save as copy

Testing Instructions

  • Open an article to edit
  • Click the button save as copy
  • See the copied article

Expected result

Hits are reset to zero after duplication.

Actual result

Hits are currently the same as the item copied from

Result after applying PR

Hits are set to zero

Documentation Changes Required

avatar hans2103 hans2103 - open - 16 Jan 2019
avatar hans2103 hans2103 - change - 16 Jan 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jan 2019
Category Administration com_content
avatar ChristineWk
ChristineWk - comment - 16 Jan 2019

Can't reproduce above, as after testing instructions I get result as stated under: Expected Result > Hits are reset to zero after duplication.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23555.

avatar ChristineWk
ChristineWk - comment - 16 Jan 2019

in addition: checked with J 3.9.2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23555.

avatar hans2103
hans2103 - comment - 16 Jan 2019

@ChristineWk that's true...
And after applying the PR you can see that the hits are set to zero.
Added extra information to issue description. Thanks

avatar hans2103 hans2103 - change - 16 Jan 2019
The description was changed
avatar hans2103 hans2103 - edited - 16 Jan 2019
avatar pe7er
pe7er - comment - 16 Jan 2019

@hans2103 I've tested it with Joomla! 3.9.3-dev but cannot reproduce the error.

Before the fix:

  • Opened an article that had 5 hits > Save as Copy > the copy has 0 hits
  • on the Articles view: selected the article that had 5 hits > Batch > Copy > the copy has 0 hits
avatar chmst
chmst - comment - 16 Jan 2019

Cannot confirm the issue. Hits are set to 0 by default when a new item is saved.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23555.

avatar hans2103
hans2103 - comment - 16 Jan 2019

sorry all.. and thank you for testing.
It seems a classic case of pebkac.

@pe7er Batch was covered in #14325

avatar hans2103 hans2103 - change - 16 Jan 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-01-16 12:58:47
Closed_By hans2103
Labels Added: ?
avatar hans2103 hans2103 - close - 16 Jan 2019

Add a Comment

Login with GitHub to post a comment