Feeling Lucky
?
[#23543] - Update view.feed.php
- Closed
- 1 Mar 2019
- Medium
- Build: staging
- # 23543
- Diff
- tonypartridge:patch-8
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #23542
Summary of Changes
We loop on ids but input could be null or empty, make sure it’s array if it is not set.
| Status | New | ⇒ | Pending |
| Category | ⇒ | com_tags Front End |
ReLater
- comment
- 24 Feb 2019
Try (array) $app->input->get('id'); instead of $app->input->get('id', array());
wlh1950
- comment
- 26 Feb 2019
(array) $app->input->get('id'); seems to work, no warnings anymore. I'll keep an eye on it.
zero-24
- comment
- 26 Feb 2019
@tonypartridge can you please apply the requested changes to the PR?
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-03-01 04:04:30 |
| Closed_By | ⇒ | Quy |
| Closed_Date | 2019-03-01 04:04:30 | ⇒ | 2019-03-01 04:04:31 |
| Closed_By | Quy | ⇒ | joomla-cms-bot |
joomla-cms-bot
- comment
- 1 Mar 2019
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/23543
Quy
- comment
- 1 Mar 2019
Closing in favor of PR #24051
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23543.
After changing the file I still get:
Invalid argument supplied for foreach() in /joomla/components/com_tags/views/tag/view.feed.php on line 36 ( foreach ($ids as $id))