Feeling Lucky
?
[#2354] - Improve $spans calculation in cPanel layout
- Closed
- 31 Oct 2013
- Medium
- Build: master
- # 2354
- Diff
- Bakual:patch-1
- Foreign ID 32446
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
The cPanel layout calculates the spans to start a new line if it goes over 12. This works fine as long as bootstrapSize is not 0. If one or more module is set to 0, the design goes crazy because it doesn't start a new line, but the module is shown with full width.
This PR sets the bootstrapSize to 12 for the calculation so a new line is properly created.
Tracker:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32446
elinw
- comment
- 31 Oct 2013
This is a good solution to the b/c break.
mbabker
- 
garyamort
-
Good find. Didn't think that people would mix modules with sizes of 0 with others.
Looked at code: Fix looks perfectly appropriate.
Thanks @Bakual