? Pending

User tests: Successful: Unsuccessful:

avatar ReLater
ReLater
13 Jan 2019

Pull Request for Issue #23401, #23529

Test

  • J4 nightly. Try to save a tag.
Error:
Too few arguments to function PlgContentJoomla::onContentBeforeSave(), 3 passed in /joomla-cms/libraries/src/Plugin/CMSPlugin.php on line 287 and exactly 4 expected
  • Apply patch and try again.
avatar ReLater ReLater - open - 13 Jan 2019
avatar ReLater ReLater - change - 13 Jan 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Jan 2019
Category com_tags Administration
avatar ReLater ReLater - change - 13 Jan 2019
Title
add $data to event_before_save
[4.0][com_tags] Fix "Too few arguments to function PlgContentJoomla::onContentBeforeSave". Add $data to event_before_save
avatar ReLater ReLater - edited - 13 Jan 2019
avatar wilsonge wilsonge - change - 13 Jan 2019
Labels Added: ?
avatar ChristineWk
ChristineWk - comment - 13 Jan 2019

I have tested this item successfully on bfae4a5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23531.

avatar ChristineWk ChristineWk - test_item - 13 Jan 2019 - Tested successfully
avatar infograf768
infograf768 - comment - 13 Jan 2019

We have the same error when we save a Menu
Too few arguments to function PlgContentJoomla::onContentBeforeSave(), 3 passed in /Applications/MAMP/htdocs/installmulti/joomla40/libraries/src/Plugin/CMSPlugin.php on line 287 and exactly 4 expected
Was'nt there a discussion somewhere about $data?

avatar ChristineWk
ChristineWk - comment - 13 Jan 2019

@infograf768

We have the same error when we save a Menu
Too few arguments to function PlgContentJoomla::onContentBeforeSave(), 3 passed in /Applications/MAMP/htdocs/installmulti/joomla40/libraries/src/Plugin/CMSPlugin.php on line 287 and exactly 4 expected
Was'nt there a discussion somewhere about $data?

yes, see here please: #23395

avatar wojsmol
wojsmol - comment - 13 Jan 2019

@infograf768 $data is now required see #23293 (comment).

avatar ReLater
ReLater - comment - 13 Jan 2019

We have the same error when we save a Menu

We had the same error but @wilsonge fixed it in a way that I copied here ;-)
@joomdonation pushed me in the right direction. Some more infos: #23276

avatar wilsonge wilsonge - change - 13 Jan 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-01-13 22:20:11
Closed_By wilsonge
avatar wilsonge wilsonge - close - 13 Jan 2019
avatar wilsonge wilsonge - merge - 13 Jan 2019
avatar wilsonge
wilsonge - comment - 13 Jan 2019

Thanks :)

avatar infograf768
infograf768 - comment - 14 Jan 2019

I guess it may have been lost in translation...
We still HAVE (not HAD) the same error for menu.
Here is the patch:
#23535

Was just hesitating between $data and $data = array()

Add a Comment

Login with GitHub to post a comment