?
avatar ghazal
ghazal
13 Jan 2019

Steps to reproduce the issue

Admin
Creating or modifying a tag via com_tags and Save
Error:
Too few arguments to function PlgContentJoomla::onContentBeforeSave(), 3 passed in /joomla-cms/libraries/src/Plugin/CMSPlugin.php on line 287 and exactly 4 expected

Front
These Menu Types created:
Compact list of tagged items
Tagged Items
List of all tags

Error:
Class 'Joomla\Component\Tags\Site\Model\TagsHelperRoute' not found
PS : I guess this should be
Joomla\Component\Tags\Site\Helper\TagsHelperRoute

System information (as much as possible)

PHP 7.2.5
Nightly Build: Sunday, 13 January 2019 (update package)

avatar ghazal ghazal - open - 13 Jan 2019
avatar joomla-cms-bot joomla-cms-bot - labeled - 13 Jan 2019
avatar ReLater
ReLater - comment - 13 Jan 2019

Concerning: "Creating or modifying a tag via com_tags and Save. Error:...."

Test #23531 please.

avatar ghazal
ghazal - comment - 14 Jan 2019

@ReLater
Thanks for correcting error 1.
Already merged.
Do you think I should make a new post for error 2 ?

avatar infograf768
infograf768 - comment - 14 Jan 2019

No use. This has not been closed in order to also correct this error. :)

avatar ghazal
ghazal - comment - 14 Jan 2019

OK.

avatar infograf768
infograf768 - comment - 14 Jan 2019

The file to correct is
.../components/com_tags/tmpl/tags/default_items.php
Adding
use Joomla\Component\Tags\Site\Helper\TagsHelperRoute; should solve it.

avatar ghazal
ghazal - comment - 14 Jan 2019

@infograf768
I tried this, it doesn't work, otherwise I would have made a pull request.

avatar infograf768
infograf768 - comment - 14 Jan 2019

It works here for a "List of all tags" menu item.
The other specific menu items for tags are broken at the moment because of the new choice.js which prevents from selecting the options for the field:

screen shot 2019-01-14 at 12 17 20

avatar infograf768
infograf768 - comment - 14 Jan 2019

BTW: I would not test anything on an "Updated" 4.0. I always test on the branch after running npm ci

avatar ghazal
ghazal - comment - 14 Jan 2019

True that my test site with composer and npm was several updates behind.
Corrected.
This solution doesn't work on front-end.
But maybe we should hold this off until the menu system is fully functional and com_tags itself is corrected because there are still some bugs.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 4 Mar 2019

@ghazal closing this Issue?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23529.

avatar franz-wohlkoenig franz-wohlkoenig - change - 4 Mar 2019
Status New Information Required
avatar ghazal
ghazal - comment - 4 Mar 2019

Yes. Sorry.

avatar ghazal ghazal - change - 4 Mar 2019
Status Information Required Closed
Closed_Date 0000-00-00 00:00:00 2019-03-04 18:26:22
Closed_By ghazal
avatar ghazal ghazal - close - 4 Mar 2019
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 4 Mar 2019

thanks @ghazal

Add a Comment

Login with GitHub to post a comment