[#23501] - [4.0] Remove show_associations field of association is not enabled
- Fixed in Code Base
- 14 Jan 2019
- Medium
- Build: 4.0-dev
- # 23501
- Diff
- joomdonation:patch-1
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This simple PR removes the field show_associations field of association is not enabled. It causes fatal error while saving article when I tested PR #12414 and @Hackwar had to add a check (which I think not necessary) to prevent the error.
Plus, it also removes some unused variables/lines of code which can be seen easily if you use a good IDE like phpstorm.
Testing Instructions
Apply patch, try to save article and confirm nothing broken. Maybe code review should be enough.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content |
| Labels |
Added:
?
|
||
I applied this patch and I could create and save an article.
I see no change in the options tab of com_content.
The field show_associations is shown when the Plugin System - Language Filter is active and it is not shown when the Plugin System - Language Filter is not active - with and without this patch.
Perhaps we can delete the line
in this PR, too.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23501.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-01-14 23:51:10 |
| Closed_By | ⇒ | wilsonge |
Thanks!
I have tested this item✅ successfully on 802acf8
ok on review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23501.