[#23493] - [4.0] Only use the global language folder for core language files
- Fixed in Code Base
- 29 Sep 2019
- Medium
- Build: 4.0-dev
- # 23493
- Diff
- Bakual:RemoveRedundantLanguageFiles
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #23489 .
Summary of Changes
Removes duplicated language files in the respective extension folder.
Moves language files for the backend template "Atum" to the global folder.
Testing Instructions
Make sure the following extensions still are translated:
- Backend Template "Atum"
- Multilingual Status Module (Backend)
- Statistics Module (Backend)
- Languagecode Plugin
- Frontend Template "Cassiopeia"
Expected result
Everything Translated
Actual result
Everything Translated, but files are in wrong (for core) location.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Modules Front End Plugins Templates (site) |
| Title |
|
||||||
| Title |
|
||||||
Imho, language files should only be present in one place, not in two. I'm quite sure that if there is a change in the language strings, it will be missing in either one of the two files.
Your example of copying the template is fine, but it still only works for the en-GB files. The translations would be lost anyway. A better way would be to improve the copy function to look (also) in the global folder for possible language files and copy those.
Your example of copying the template is fine, but it still only works for the en-GB files. The translations would be lost anyway.
Someone copying a template should be aware of this imho.
A better way would be to improve the copy function to look (also) in the global folder for possible language files and copy those.
Agree, but until someone does propose a patch, we should keep 3.x behaviour.
Remove language folder from file list in manifest files too:
administrator\modules\mod_multilangstatus\mod_multilangstatus.xml
administrator\modules\mod_stats_admin\mod_stats_admin.xml
administrator\modules\mod_version\mod_version.xml
plugins\system\languagecode\languagecode.xml
| Category | Administration Language & Strings Modules Front End Plugins Templates (site) | ⇒ | Administration Front End Modules Plugins Templates (site) |
Can you look at resolving the conflicts so that this can be tested please.
| Category | Administration Modules Front End Plugins Templates (site) | ⇒ | Administration Language & Strings Modules Front End Plugins Templates (site) |
Conflicts solved
has still not been taken care of in TemplateModel.php
Imho this is another issue which has to be handled in a separate PR.
Because the current implementation is buggy as well as it only copies the english files and ignores the available translations. We would need code which takes care of all files (or none).
I have tested this item
Successfully tested.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23493.
I have tested this item
All extensions were translated.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23493.
| Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
Let's not forget we have to correct the Copy Template functionnality...
Create an issue and it won't be forgotten
I have tested this item
works as described
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23493.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-09-29 18:52:16 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks
I do not agree with this change.
A template can be duplicated and therefore also its language files.
When duplicated, the new copy of the template should contain a language folder with the modified language files.
The core templates language files should be present in both the template folder and core, which is not the case for Atum.
Therefore a correct patch should add Atum language files into a specific language folder in the template folder itself.