? ? ? Success

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
9 Jan 2019

Pull Request for Issue #23489 .

Summary of Changes

Removes duplicated language files in the respective extension folder.
Moves language files for the backend template "Atum" to the global folder.

Testing Instructions

Make sure the following extensions still are translated:

  • Backend Template "Atum"
  • Multilingual Status Module (Backend)
  • Statistics Module (Backend)
  • Languagecode Plugin
  • Frontend Template "Cassiopeia"

Expected result

Everything Translated

Actual result

Everything Translated, but files are in wrong (for core) location.

Documentation Changes Required

None

avatar Bakual Bakual - open - 9 Jan 2019
avatar Bakual Bakual - change - 9 Jan 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Jan 2019
Category Administration Language & Strings Modules Front End Plugins Templates (site)
avatar Bakual Bakual - change - 9 Jan 2019
Title
Only use the global language folder for core language files
[4.0] Only use the global language folder for core language files
avatar Bakual Bakual - change - 9 Jan 2019
Title
Only use the global language folder for core language files
[4.0] Only use the global language folder for core language files
avatar Bakual Bakual - edited - 9 Jan 2019
avatar infograf768
infograf768 - comment - 10 Jan 2019

I do not agree with this change.
A template can be duplicated and therefore also its language files.
When duplicated, the new copy of the template should contain a language folder with the modified language files.

The core templates language files should be present in both the template folder and core, which is not the case for Atum.

Therefore a correct patch should add Atum language files into a specific language folder in the template folder itself.

avatar Bakual
Bakual - comment - 10 Jan 2019

Imho, language files should only be present in one place, not in two. I'm quite sure that if there is a change in the language strings, it will be missing in either one of the two files.

Your example of copying the template is fine, but it still only works for the en-GB files. The translations would be lost anyway. A better way would be to improve the copy function to look (also) in the global folder for possible language files and copy those.

avatar infograf768
infograf768 - comment - 10 Jan 2019

Your example of copying the template is fine, but it still only works for the en-GB files. The translations would be lost anyway.

Someone copying a template should be aware of this imho.

A better way would be to improve the copy function to look (also) in the global folder for possible language files and copy those.

Agree, but until someone does propose a patch, we should keep 3.x behaviour.

avatar SharkyKZ
SharkyKZ - comment - 10 Jan 2019

Remove language folder from file list in manifest files too:

administrator\modules\mod_multilangstatus\mod_multilangstatus.xml
administrator\modules\mod_stats_admin\mod_stats_admin.xml
administrator\modules\mod_version\mod_version.xml
plugins\system\languagecode\languagecode.xml
avatar franz-wohlkoenig franz-wohlkoenig - change - 11 Apr 2019
Category Administration Language & Strings Modules Front End Plugins Templates (site) Administration Front End Modules Plugins Templates (site)
avatar brianteeman
brianteeman - comment - 16 Jul 2019

Can you look at resolving the conflicts so that this can be tested please.

avatar joomla-cms-bot joomla-cms-bot - change - 16 Jul 2019
Category Administration Modules Front End Plugins Templates (site) Administration Language & Strings Modules Front End Plugins Templates (site)
avatar Bakual
Bakual - comment - 16 Jul 2019

Conflicts solved

avatar Bakual
Bakual - comment - 16 Jul 2019

Also updated manifests (somehow missed that comment by @SharkyKZ )

avatar infograf768
infograf768 - comment - 18 Jul 2019

#23493 (comment)

has still not been taken care of in TemplateModel.php

avatar Bakual
Bakual - comment - 18 Jul 2019

Imho this is another issue which has to be handled in a separate PR.
Because the current implementation is buggy as well as it only copies the english files and ignores the available translations. We would need code which takes care of all files (or none).

avatar roland-d
roland-d - comment - 31 Aug 2019

@Bakual If this is ready for testing can you please fix the merge conflicts so I can get this tested?

avatar Bakual
Bakual - comment - 1 Sep 2019

@roland-d Merged 4.0 branch

avatar bees4ever bees4ever - test_item - 2 Sep 2019 - Tested successfully
avatar bees4ever
bees4ever - comment - 2 Sep 2019

I have tested this item successfully on 7adef41

Successfully tested.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23493.

avatar Lyro274 Lyro274 - test_item - 2 Sep 2019 - Tested successfully
avatar Lyro274
Lyro274 - comment - 2 Sep 2019

I have tested this item successfully on 7adef41

All extensions were translated.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23493.

avatar franz-wohlkoenig franz-wohlkoenig - change - 2 Sep 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 2 Sep 2019

Status "Ready To Commit".

avatar infograf768
infograf768 - comment - 2 Sep 2019

Let's not forget we have to correct the Copy Template functionnality...

avatar brianteeman
brianteeman - comment - 2 Sep 2019

Create an issue and it won't be forgotten

avatar itsMeAnimated
itsMeAnimated - comment - 3 Sep 2019

I have tested this item successfully on 7adef41
works as described


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23493.

avatar wilsonge wilsonge - change - 29 Sep 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-09-29 18:52:16
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 29 Sep 2019
avatar wilsonge wilsonge - merge - 29 Sep 2019
avatar wilsonge
wilsonge - comment - 29 Sep 2019

Thanks

Add a Comment

Login with GitHub to post a comment