[#23460] - [4.0] Add back button to the transitions and stages view button toolbars
- Fixed in Code Base
- 8 Jan 2019
- Medium
- Build: 4.0-dev
- # 23460
- Diff
- bembelimen:workflow-add-back-buttons
User tests: Successful: Unsuccessful:
Summary of Changes
A few weeks ago the submenu was removed from the workflow and it is very circuitous to switch from stages to transitions. This improves the workflow with some "back" buttons.
Testing Instructions
Go to the stages/transitions view and check the back button on the top left toolbar
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_workflow |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23460.
Using arrow-left makes no sense if the site is RTL
You're right, what icon would you use?
You can still use an arrow but make the direction conditional on the language - see j-toggle-sidebar for an example
Rips is green now.
I have tested this item
I've tested the functionality. I can't say anything regarding the icon.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23460.
@bembelimen
You can use:
$arrow = Factory::getLanguage()->isRtl() ? 'arrow-right' : 'arrow-left';
ToolbarHelper::link('index.php?option=com_workflow&view=workflows&extension=' . $this->escape($this->workflow->extension),
'JTOOLBAR_BACK', $arrow);
PHPCS issues :) http://ci.joomla.org/joomla/joomla-cms/13521/8
Sorry was to slow, thanks everyone for the improvements!
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-01-08 19:35:23 |
| Closed_By | ⇒ | wilsonge |
@zero-24 @SniperSister Please check this tests failure as this is related to rips.