? Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
6 Jan 2019

Summary of Changes

A few weeks ago the submenu was removed from the workflow and it is very circuitous to switch from stages to transitions. This improves the workflow with some "back" buttons.

Testing Instructions

Go to the stages/transitions view and check the back button on the top left toolbar

avatar bembelimen bembelimen - open - 6 Jan 2019
avatar bembelimen bembelimen - change - 6 Jan 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Jan 2019
Category Administration com_workflow
avatar bembelimen bembelimen - change - 6 Jan 2019
Labels Added: ?
avatar wojsmol
wojsmol - comment - 6 Jan 2019

@zero-24 @SniperSister Please check this tests failure as this is related to rips.

avatar chmst
chmst - comment - 6 Jan 2019

I have tested this item successfully on ae32cfa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23460.

avatar chmst chmst - test_item - 6 Jan 2019 - Tested successfully
avatar brianteeman
brianteeman - comment - 6 Jan 2019

Using arrow-left makes no sense if the site is RTL

avatar bembelimen
bembelimen - comment - 6 Jan 2019

You're right, what icon would you use?

avatar brianteeman
brianteeman - comment - 6 Jan 2019

You can still use an arrow but make the direction conditional on the language - see j-toggle-sidebar for an example

$toggleSidebarIcon = $('#j-toggle-sidebar-icon'),

avatar zero-24
zero-24 - comment - 6 Jan 2019

Rips is green now.

avatar Hackwar
Hackwar - comment - 7 Jan 2019

I have tested this item successfully on 1b508c4

I've tested the functionality. I can't say anything regarding the icon.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23460.

avatar Hackwar Hackwar - test_item - 7 Jan 2019 - Tested successfully
avatar infograf768
infograf768 - comment - 7 Jan 2019

@bembelimen
You can use:

		$arrow = Factory::getLanguage()->isRtl() ? 'arrow-right' : 'arrow-left';

		ToolbarHelper::link('index.php?option=com_workflow&view=workflows&extension=' . $this->escape($this->workflow->extension),
			'JTOOLBAR_BACK', $arrow);
avatar zero-24
zero-24 - comment - 7 Jan 2019
avatar bembelimen
bembelimen - comment - 8 Jan 2019

Sorry was to slow, thanks everyone for the improvements!

e60c9be 8 Jan 2019 avatar wilsonge CS
avatar wilsonge wilsonge - change - 8 Jan 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-01-08 19:35:23
Closed_By wilsonge
avatar wilsonge wilsonge - close - 8 Jan 2019
avatar wilsonge wilsonge - merge - 8 Jan 2019

Add a Comment

Login with GitHub to post a comment