Feeling Lucky
?
[#23445] - Remove unused postSaveHook methods
- Fixed in Code Base
- 4 Jan 2019
- Medium
- Build: 4.0-dev
- # 23445
- Diff
- bembelimen:fix-newsfeed-post-save-hook
User tests: Successful: Unsuccessful:
Pull Request for Issue #23403
Summary of Changes
Remove unused postSaveHook methods (fallback to the default) and fix the error in the mentioned issue
Testing Instructions
Delete newsfeed items
Expected result
No errors, items deleted
Actual result
Error message
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_newsfeeds |
chmst
- comment
- 4 Jan 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23445.
dgrammatiko
- comment
- 4 Jan 2019
@bembelimen you need to do anther PR in the staging repo to deprecate these methods... Just saying..
dgrammatiko
- comment
- 4 Jan 2019
@mbabker my bad then I should have checked that this was overriding the parent class...
@bembelimen ignore me...
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-01-04 23:48:34 |
| Closed_By | ⇒ | wilsonge |
I have tested this item✅ successfully on 51dfad1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23445.