? Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
4 Jan 2019

Pull Request for Issue #23403

Summary of Changes

Remove unused postSaveHook methods (fallback to the default) and fix the error in the mentioned issue

Testing Instructions

Delete newsfeed items

Expected result

No errors, items deleted

Actual result

Error message

avatar bembelimen bembelimen - open - 4 Jan 2019
avatar bembelimen bembelimen - change - 4 Jan 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Jan 2019
Category Administration com_newsfeeds
avatar chmst
chmst - comment - 4 Jan 2019

I have tested this item successfully on 51dfad1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23445.

avatar chmst
chmst - comment - 4 Jan 2019

I have tested this item successfully on 51dfad1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23445.

avatar chmst chmst - test_item - 4 Jan 2019 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 4 Jan 2019

@bembelimen you need to do anther PR in the staging repo to deprecate these methods... Just saying..

avatar mbabker
mbabker - comment - 4 Jan 2019

A deprecation notice isn't needed when you're removing an overridden method from a parent class. Removing it just means the parent class' definition will be used. Same as with #23303

avatar dgrammatiko
dgrammatiko - comment - 4 Jan 2019

@mbabker my bad then I should have checked that this was overriding the parent class...
@bembelimen ignore me... ?

avatar wilsonge wilsonge - change - 4 Jan 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 4 Jan 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-01-04 23:48:34
Closed_By wilsonge
avatar wilsonge wilsonge - close - 4 Jan 2019
avatar wilsonge wilsonge - merge - 4 Jan 2019

Add a Comment

Login with GitHub to post a comment