? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
31 Dec 2018

Summary of Changes

Make sure the SECURITY.md is not included in the final packages

Testing Instructions

Build an release with the shipped build tools. => no SECURITY.md file in the release package anymore
code review

Expected result

no SECURITY.md file in the release package anymore

Actual result

the SECURITY.md file is in the release packages

Documentation Changes Required

I'm not sure how the latest version runs but this need to be adopted to the build tools for the nightly builds too.

avatar zero-24 zero-24 - open - 31 Dec 2018
avatar zero-24 zero-24 - change - 31 Dec 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Dec 2018
Category Repository
avatar mbabker
mbabker - comment - 31 Dec 2018

I'm not sure how the latest version runs but this need to be adopted to the build tools for the nightly builds too.

The nightlies have been using this file for quite some time. There is no need to specify "nightly builds have to be fixed too"; the only part of that you can't fix in fixing this file is the part where the packages are transferred to the Developer Network.

avatar zero-24
zero-24 - comment - 31 Dec 2018

Thanks ?

avatar wilsonge wilsonge - change - 31 Dec 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-12-31 17:09:10
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 31 Dec 2018
avatar wilsonge wilsonge - merge - 31 Dec 2018
avatar wilsonge
wilsonge - comment - 31 Dec 2018

Thanks!

Add a Comment

Login with GitHub to post a comment