[#23409] - Feature #23408 feat: New configs to display featured contacts at the top & number of contacts to display on a contact list page.
- Closed
- 29 Jan 2019
- Medium
- Build: staging
- # 23409
- Diff
- vaibhavsTekdi:featuredcontactsconfigByVaibhav
User tests: Successful: Unsuccessful:
Is your feature request related to a problem? Please describe.
Yes, the user cannot able to see the featured contacts at the top in the contact list & also not able to set the number of contacts to display on a single page.
Describe the solution you'd like
Add new configs are as follows :
- Contacts to List: Should have numbers to show contacts on list page with 'All' option.
- Sort By: Featured Contacts Ordering (It will display the featured contacts at the top in the contact list)
Add above configs about showing the number of contacts(default numbers) to display on contact list page & also add a new sort option as 'Featured Contacts Ordering' in sort by config under 'Contacts: Options >> List Layouts' tab as global at the component level.
Also, these configs should available at Joomla contact menu having 'List Contacts in a Category' menu type. Both the configs should have global values as default values.
Contacts list should display according to the contact menu level configs.
Additional context
With the existing config(s) at Contacts component level options & Contacts menu level, the user cannot able to see the featured contacts at the top in the contact list & also not able to set the number of contacts to display on a single page.
It is showing the contacts sort by name or ordering or sort name etc.
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_contact Language & Strings Front End |
| Title |
|
||||||
| Labels |
Added:
?
?
|
||
Please modify constants below to
COM_CONTACT_etcand move both strings to the com_contact.ini file
Articles similar strings should never have been created as JGLOBAL_and placed in en-GB.ini.JGLOBAL_NUMBER_CONTACTS_LIST_DESC="Default number of contacts to list on a page."
JGLOBAL_NUMBER_CONTACTS_LIST_LABEL="# Contacts to List"
Modified both the constants & moved to the com_contact.ini file.
_N_ITEMS in the constants makes no sense here as they are Label and Description which do not use a sprintf and variable.
Please just use
label="COM_CONTACT_NUMBER_CONTACTS_LIST_LABEL"
description="COM_CONTACT_NUMBER_CONTACTS_LIST_DESC"
_N_ITEMSin the constants makes no sense here as they are Label and Description which do not use a sprintf and variable.
Please just use
label="COM_CONTACT_NUMBER_CONTACTS_LIST_LABEL"
description="COM_CONTACT_NUMBER_CONTACTS_LIST_DESC"
Fixed.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23409.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23409.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23409.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23409.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23409.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23409.
| Labels |
Added:
?
|
||
I have tested this item
## config related to pagination works fine
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23409.
I have tested this item
Updated code about pagination & this feature working fine.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23409.
I have tested this item
Checked with updated code about pagination and its working fine.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23409.
@vaibhavsTekdi please rebase this feature to 4.0 and create a new PR, this PR will likely not go into 3.9
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-01-29 11:20:42 |
| Closed_By | ⇒ | vaibhavsTekdi |
Please modify constants below to
COM_CONTACT_etcand move both strings to the com_contact.ini fileArticles similar strings should never have been created as JGLOBAL_and placed in en-GB.ini.
JGLOBAL_NUMBER_CONTACTS_LIST_DESC="Default number of contacts to list on a page."
JGLOBAL_NUMBER_CONTACTS_LIST_LABEL="# Contacts to List"