PR-4.0-dev RTC

Success

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
28 Dec 2018

Summary of Changes

At the moment the custom fields are in the submenu for contact. With this PR The two submenu items are moved to the main menu like in the other extensions.

Testing Instructions

  • Apply patch
  • Reinstall Joomla!
  • Check menu items for contact
  • disable/enable custom fields for contact to check display/hide
avatar bembelimen bembelimen - open - 28 Dec 2018
avatar bembelimen bembelimen - change - 28 Dec 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Dec 2018
Category SQL Administration com_admin Postgresql com_contact Modules Installation
avatar chmst
chmst - comment - 28 Dec 2018

I have tested this item successfully on 1846d32


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23366.

avatar chmst chmst - test_item - 28 Dec 2018 - Tested successfully
avatar Hackwar
Hackwar - comment - 30 Dec 2018

I have tested this item successfully on 1846d32

Tested successfully. We shouldd really merge in the testing sample data plugin and drop the SQL files.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23366.

avatar Hackwar Hackwar - test_item - 30 Dec 2018 - Tested successfully
avatar Quy Quy - change - 30 Dec 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 30 Dec 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23366.

avatar infograf768 infograf768 - change - 30 Dec 2018
Title
Move custom fields from submenu to main menu in contact
[4.0] Move custom fields from submenu to main menu in contact
avatar infograf768 infograf768 - change - 30 Dec 2018
Title
Move custom fields from submenu to main menu in contact
[4.0] Move custom fields from submenu to main menu in contact
avatar infograf768 infograf768 - edited - 30 Dec 2018
avatar rdeutz rdeutz - change - 19 Jan 2019
Labels Added: PR-4.0-dev RTC
avatar brianteeman
brianteeman - comment - 21 Feb 2019

can you fix the conflicts please

avatar bembelimen bembelimen - change - 16 Apr 2019
Labels Removed: J4 Issue
avatar brianteeman
brianteeman - comment - 13 May 2019

@bembelimen can you fix the conflicts please and then we can get this merged

avatar wilsonge wilsonge - change - 23 Jun 2019
Status Ready to Commit Pending
avatar wilsonge
wilsonge - comment - 23 Jun 2019

Removing rtc until conflicts are fixed. Mainly just to avoid me re-reading this PR every 2 weeks when I go through the RTC pile. Whenever they are fixed someone can mark this back as RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23366.

avatar brianteeman
brianteeman - comment - 26 Jun 2019

@bembelimen please can you fix the conflicts

avatar brianteeman
brianteeman - comment - 30 Jun 2019

I tried to test this with the view to resolving the conflicts and submitting it as a new pr but it is not a correct PR or the code required has changed since this was created

  1. disable/enable custom fields for contact to check display/hide
    This had no effect

  2. The separator between contacts and fields is not rendered correctly
    <li class="divider" role="presentation"><a class="no-dropdown" href="#"><span class="sidebar-item-title"></span></a></li>
    Should be
    <li class="divider" role="presentation"><span></span></li>
    Otherwise it becomes a clickable and focusable item

Add a Comment

Login with GitHub to post a comment