Language Change PR-4.0-dev

Failure

User tests: Successful: Unsuccessful:

avatar wojsmol
wojsmol
27 Dec 2018

Pull Request for Issue #23345 .

Summary of Changes

Confirm Password field removed from user edit in backend

Testing Instructions

code review or test whether user edit forks as expected and Confirm Password is not present.

Expected result

No Confirm Password field and user edit works.

Actual result

Confirm Password field exists and user edit works

Documentation Changes Required

no

avatar wojsmol wojsmol - open - 27 Dec 2018
avatar wojsmol wojsmol - change - 27 Dec 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Dec 2018
Category Administration com_users Language & Strings
avatar chmst
chmst - comment - 27 Dec 2018

I see that the password is removed from the user edit view.
But there are about 30 places where the password2 is used in the code.
It is checked in the models and appears in different views and models in the frontend.

So I think it is too early for submitting a test result.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23357.
avatar tonypartridge
tonypartridge - comment - 27 Dec 2018

Why would you want to do this? For BC you should at least add it as a config option which is showing both by default.

avatar chmst
chmst - comment - 27 Dec 2018

The second password is only wasted time and no longer up to date in modern apps (my opinion).
I do not insist but why then do we have the new password with the "plain text" button?

If it is a B/C problem, we need a param and or a solution for the password2 check. But I do not see a big B/C problem. The password2 is not in the database. It could be used in extensions of the registration form, but I am sure that there we can find a solution.

avatar wojsmol wojsmol - change - 27 Dec 2018
Labels Added: Language Change PR-4.0-dev
avatar joomla-cms-bot joomla-cms-bot - change - 27 Dec 2018
Category Administration com_users Language & Strings Administration com_admin com_users Language & Strings Front End Libraries
avatar brianteeman
brianteeman - comment - 28 Dec 2018

I don't see the reason for this change

avatar dgrammatiko
dgrammatiko - comment - 28 Dec 2018

should at least add it as a config option

Please NO more switches...

avatar chmst
chmst - comment - 4 Jan 2019

I have tested and it looks great. But in the confirm.xml still is a password2. Could you remove this too?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23357.

avatar wojsmol
wojsmol - comment - 5 Jan 2019

@chmst Can you post a path to confirm.xml file in question?

avatar chmst
chmst - comment - 5 Jan 2019

It is components\com_users\forms\reset_complete.xml

avatar chmst
chmst - comment - 5 Jan 2019

I have tested this item successfully on a921c44

Thank you @wojsmol


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23357.

avatar chmst chmst - test_item - 5 Jan 2019 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 11 Apr 2019
Category Administration com_users Language & Strings com_admin Front End Libraries Administration com_admin com_users Front End Libraries
avatar tonypartridge
tonypartridge - comment - 13 Jul 2019

Thinking about this, if we proceed with it... what about showing the password rather than hiding by default so people can see if it's typed correctly?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23357.

avatar dgrammatiko
dgrammatiko - comment - 13 Jul 2019

@tonypartridge the password shouldn't be visible by default and also in the field (password) was added a button to reveal the text just for this scenario. FWIW the field still needs to become a custom element, there used to be a PR by me and would be really nice if someone resurrects it because the current code is not production-ready...

Add a Comment

Login with GitHub to post a comment