? Pending

User tests: Successful: Unsuccessful:

avatar corejoomla
corejoomla
25 Dec 2018

When loaded both captcha and editor plugins on same page, onDisplay function on both plugins conflict with each other as they have different number of parameters.

Ref: #23322

Pull Request for Issue #23322 .

Summary of Changes

Added a new proxy function for b/w compatibility and renamed the onDisplay function to onDisplayCaptcha

Testing Instructions

On any form page where the editor loaded, add below code

JPluginHelper::importPlugin('captcha');
$app->triggerEvent('onInit', array(null, 'ca_captcha'));
$recaptcha = $app->triggerEvent('onDisplay', array(null, 'ca_captcha', 'class=""'));
echo (isset($recaptcha[0])) ? $recaptcha[0] : '';

Expected result

Captcha loaded fine and editor works fine.

Documentation Changes Required

Need to update the documentation with the renamed onDisplayCaptcha function name.

avatar corejoomla corejoomla - open - 25 Dec 2018
avatar corejoomla corejoomla - change - 25 Dec 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Dec 2018
Category Front End Plugins
avatar corejoomla corejoomla - change - 25 Dec 2018
Labels Added: ?
avatar corejoomla
corejoomla - comment - 25 Dec 2018

This PR should be applied on staging as the issue exist on current version as well. So closing this and opening another PR.

avatar corejoomla corejoomla - change - 25 Dec 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-12-25 14:02:53
Closed_By corejoomla
avatar corejoomla corejoomla - close - 25 Dec 2018

Add a Comment

Login with GitHub to post a comment