? Pending

User tests: Successful: Unsuccessful:

avatar Ninja-007
Ninja-007
23 Dec 2018

Default bootstrap grid is 4+ 4+ 4. It creates small middle section. To increase it the column parameters are specified.

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

avatar Ninja-007 Ninja-007 - open - 23 Dec 2018
avatar Ninja-007 Ninja-007 - change - 23 Dec 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Dec 2018
Category Front End Templates (site)
avatar SharkyKZ
SharkyKZ - comment - 23 Dec 2018

Cassiopeia doesn't use Bootstrap grip. Sidebars take up about 25% width each and the rest is allocated to the component area.

avatar Ninja-007
Ninja-007 - comment - 23 Dec 2018

@SharkyKZ I had used fluid style in container. Then it took 4 + 4 + 4. The component area did not have enough space and sidebars had extra space. When column width is not specified then booststrap allocates equal space to all columns. BTW, the pull request code creates problem for small screen size.

The sidebar space should be reduced to 15% +15% from 25% + 25%.

avatar Ninja-007 Ninja-007 - change - 24 Dec 2018
Labels Added: ?
avatar mbabker
mbabker - comment - 24 Dec 2018

As was mentioned before, Cassiopeia does NOT use Bootstrap's grid system. It is using CSS Grid. As long as this PR is introducing Bootstrap's grid into the template, it is invalid. If you want to change aspect's of the template's grid, you will need to update the definition in the appropriate SCSS files.

avatar Ninja-007
Ninja-007 - comment - 24 Dec 2018

@mbabker Thanks
I shall do that.

avatar Ninja-007 Ninja-007 - close - 24 Dec 2018
avatar Ninja-007 Ninja-007 - change - 24 Dec 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-12-24 14:21:50
Closed_By Ninja-007

Add a Comment

Login with GitHub to post a comment