[#23320] - jdatabase importer exporter
- Closed
- 27 Apr 2019
- Medium
- Build: staging
- # 23320
- Diff
- twister65:pgsql_transfer
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure continuous-integration/drone/pr the build failed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Retrieving PR #14272 (and #10991) to fix the PostgreSQL exporter and importer bugs.
This PR can be tested with any database driver supported by Joomla.
This is about exporting and importing any database with a command-line interface (it can be placed in cronjob to schedule the database backup).
Summary of Changes
- Fix folder path.
- Fix postgresql issues :
- Fix the default value of the table.
- Gets, sets the
last_valueandis_calledsequence attributes. - Fix key query.
- Fix text default value.
- Apply changes to unit tests.
- Fix the execution of queries (xmlToCreate) with the pgsql (PDO) driver.
- Add unique constraints.
- Convert PostgreSQL BLOB data (bytea).
Testing Instructions
- Select a database driver and save it in System -> Global Configuration -> Server ->Database Type
- Go to the cli folder of your website.
- Export all tables and data to the folder :
php exporter.php --all --folder <folder_path> - Delete and create an empty database with the same name.
- Overwriting the database can also be done. Verify that changes are applied.
- Import all from folder:
php importer.php --all --folder <folder_path>
You can also :
- Export all tables and data in zip file :
php exporter.php --all --mode zip - Export a table :
php exporter.php --table <table_name> - Export a table as a .zip file :
php exporter.php --table <table_name> --mode zip - Import a table :
php importer.php --table <table_name>
Expected result
Export/import tables with structure (keys, constraints, sequences) and data.
Actual result
Does not export/import views, stored procedures and triggers (optional for the Joomla database).
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Postgresql Libraries |
| Labels |
Added:
?
|
||
| Category | Postgresql Libraries | ⇒ | CLI Postgresql Libraries MS SQL Unit Tests |
| Title |
|
||||||
| Labels |
Added:
?
|
||
is this ready to test ?
p.s
btw awesome work
Yes it is.
Thanks.
| Title |
|
||||||
not so sure if this work can really have a chance to be merged on 3.X branch, i will hope so
i would like to hear some words from @joomla/maintainers
| Title |
|
||||||
| Title |
|
||||||
@HLeithner comment on above Question by @alikon please?
I'm sorry but this is a new feature and has to go into j4
@twister65 can you rebase this PR on J4?
Yes, I can rebase this PR in the Joomla Framework Database Package:
https://github.com/joomla-framework/database
Closed as rebased on J4.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-04-27 04:41:30 |
| Closed_By | ⇒ | franz-wohlkoenig | |
| Labels |
Added:
?
Removed: J3 Issue |
||
PostgreSQL automatically creates a unique index when a unique constraint or primary key is defined for a table. We need to modify table by adding a unique constraint on a column, instead of creating a unique index.
This query creates unique index:
joomla-cms/libraries/joomla/database/importer/postgresql.php
Line 152 in be51ebe
Here, a unique constraint is defined for a table:
joomla-cms/libraries/joomla/database/importer/mysqli.php
Line 114 in be51ebe