? Pending

User tests: Successful: Unsuccessful:

avatar thuebschmann
thuebschmann
21 Dec 2018

Pull Request for Issue # .

Summary of Changes

Remove type Attribute vom Inline script

Testing Instructions

enable emailcloack plugin
set document->isHTML5(true)
have an emial in Content
Check the gernerated page with https://validator.w3.org/nu/

avatar thuebschmann thuebschmann - open - 21 Dec 2018
avatar thuebschmann thuebschmann - change - 21 Dec 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Dec 2018
Category Libraries
avatar SharkyKZ
SharkyKZ - comment - 21 Dec 2018

This causes validation errors on non-HTML5 pages.

avatar richard67
richard67 - comment - 21 Dec 2018

See also comment here: #23300 (comment)

avatar Bakual
Bakual - comment - 21 Dec 2018

If you really want to get rid of that type attribute, you'd have to check if the document is set to HTML5 first and only then remove the type.

I'll close this PR as it is wrong in the current state.

avatar Bakual Bakual - change - 21 Dec 2018
Title
Remove type Attribute from <script> tag
Remove type Attribute from tag
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-12-21 12:14:22
Closed_By Bakual
Labels Added: ?
avatar Bakual Bakual - close - 21 Dec 2018

Add a Comment

Login with GitHub to post a comment