[#23303] - Remove logic in library extension updates that causes them to be uninstalled for some unknown reason that makes absolutely zero sense
- Fixed in Code Base
- 24 Dec 2018
- Medium
- Build: staging
- # 23303
- Diff
- mbabker:i-really-hate-myself
User tests: Successful: Unsuccessful:
Pull Request for https://twitter.com/akeebabackup/status/1075379522613190657
Summary of Changes
Removes the uninstallation of library extensions when updating them. Because this is just fatally flawed logic.
Testing Instructions
Find a library extension. Install an older version of it. Update it to the latest version. It should still work, now the library will have a consistent ID in the extensions table and using the install script features is actually a safe thing to do.
Expected result
Libraries aren't fatally destroyed when updating them.
Actual result
Libraries are fatally destroyed when updating them, and heaven forbid there's an error during the install/update process (like an install script aborting things...).
Documentation Changes Required
If this fatally flawed behavior is documented somewhere, fix said documentation and offer condolences to those who have had to work around it for the last 9 years.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
There are other setup steps required on the update path. The parent class
takes care of those. Deprecating this is not necessary.
On Wed, Dec 19, 2018 at 12:34 PM Tony Partridge notifications@github.com
wrote:
Without starting a debate
? ... what if we deprecate the function and
just return install within it for now incase anyone is calling the function
directly.—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#23303 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfoSgI_WGwfqXpzr0D4Tv7c_w76r6Vks5u6oapgaJpZM4ZadNL
.
--
- Michael Please pardon any errors, this message was sent from my iPhone.
Ok great! Will get a test in later
On 19 Dec 2018, 18:37 +0000, Michael Babker notifications@github.com, wrote:
There are other setup steps required on the update path. The parent class
takes care of those. Deprecating this is not necessary.On Wed, Dec 19, 2018 at 12:34 PM Tony Partridge notifications@github.com
wrote:Without starting a debate
? ... what if we deprecate the function and
just return install within it for now incase anyone is calling the function
directly.—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#23303 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfoSgI_WGwfqXpzr0D4Tv7c_w76r6Vks5u6oapgaJpZM4ZadNL
.--
- Michael Please pardon any errors, this message was sent from my iPhone.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
I have tested this item
Testing installing, upgrading and uninstalling a custom library.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23303.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23303.
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-12-24 13:19:11 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Without starting a debate? ... what if we deprecate the function and just return install within it for now incase anyone is calling the function directly.