? ? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
18 Dec 2018

Summary of Changes

When it is a Tags page, the id is an array. The Related Items module should not use this id, but it does the warning.

index.php?option=com_tags&view=tag&id[0]=2&Itemid=475

Testing Instructions

Install demo.
Under Extensions > Modules, assign Articles Related Items to Right [position-7] on all pages.
On the front end, click Tagged items.

Actual result

Warning: explode() expects parameter 2 to be string, array given in \modules\mod_related_items\helper.php on line 56

Documentation Changes Required

No

avatar Quy Quy - open - 18 Dec 2018
avatar Quy Quy - change - 18 Dec 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Dec 2018
Category Modules Front End
avatar Quy Quy - change - 18 Dec 2018
Title
[mod_related_items] Fix when id is not an array
[mod_related_items] Fix when id is an array
avatar Quy Quy - edited - 18 Dec 2018
avatar SharkyKZ
SharkyKZ - comment - 18 Dec 2018

I have tested this item successfully on 2fc2344


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23298.

avatar SharkyKZ SharkyKZ - test_item - 18 Dec 2018 - Tested successfully
avatar viocassel
viocassel - comment - 19 Dec 2018

I have tested this item successfully on 2fc2344


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23298.

avatar viocassel viocassel - test_item - 19 Dec 2018 - Tested successfully
avatar Quy Quy - change - 19 Dec 2018
The description was changed
Status Pending Ready to Commit
avatar Quy Quy - edited - 19 Dec 2018
avatar Quy
Quy - comment - 19 Dec 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23298.

avatar Quy
Quy - comment - 19 Dec 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23298.

avatar mbabker mbabker - change - 20 Dec 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-12-20 15:26:42
Closed_By mbabker
Labels Added: ? ?
avatar mbabker mbabker - close - 20 Dec 2018
avatar mbabker mbabker - merge - 20 Dec 2018

Add a Comment

Login with GitHub to post a comment