[#23248] - [3.x] Trim extra spaces from download URL in com_installer and com_joomlaupdate
- Fixed in Code Base
- 18 Dec 2018
- Medium
- Build: staging
- # 23248
- Diff
- zero-24:fixDownloadURL
User tests: Successful: Unsuccessful:
Summary of Changes
Trim extra spaces from download URL as we do in other places in the installer already as it should be consisted. I have extended this PR to the new downloadsource tag too.
cc @astridx
Testing Instructions
Install this component: https://github.com/astridx/mod_agiframewrapper/releases/tag/v0.0.2
See it finds the update to 0.0.3
Notice that when you try to install it it gets an error (can't download the package)
apply the patch
try to apply the update again
Expected result
Update works
Actual result
Update errors with "Can't download package"
Documentation Changes Required
None.
More Information
The reason for that extra spaces is that here: https://github.com/astridx/mod_agiframewrapper/blob/v0.0.3/agiframewrapper-update.xml#L57-L63 there is a return an this gets into the variable.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer com_joomlaupdate |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23248.
Wouldn't it be better to fix the XML file instead?
@SharkyKZ
You are right, one solution is to change the XML-Document.
But: White space characters and line breaks are permitted in XML content (https://www.w3.org/TR/xml/#charsets). So the XML-Document is valid.
And others had my problem, too. For example here: https://www.kunena.org/forum/k-3-0-installation-and-upgrade/132397-illegal-characters-found-in-url
If you insert an url with containing white space in the address field of a browser, the browser trims it, too.
Why should not we do this in Joomla Updater?
The part about XML validity is irrelevant. The content contains characters it should not contain. 3rd parties should fix their manifests.
If this is "fixed" in core, the same needs to be done literally where XML forms are used. All because of some 3rd parties who intentionally add garbage characters to their forms.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23248.
rtc
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23248.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-12-18 02:42:11 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I tested this successful. Thank you very much @zero-24
