Better to fix the override

We can do that. But this also affects 3rd party templates.

thats why its called an override. if they override something then they have to keep it up to date

We can't force every template to "fix the override". A lot of core, and a lot of documentation and tutorials, still say to use $field->label and $field->input to render each field's elements manually, which was honestly the only way to do things from 1.6 up to 3.2 when the render* methods were added. Less documentation and tutorials document things using those, and much of core still doesn't. So this is honestly yet another compromise that will fix things in the least painful way for the highest number of users.

This PR is not included in 3.9.2 RC.

Is it ok for everybody ?

Without testing and review no patch is merged to core. There hasn't been much testing and review here.

I can't find "HumanTesting" option on this PR and "all checks have passed".

@pmleconte https://issues.joomla.org/tracker/joomla-cms/23205

Using Beez, this patch does not open a modal but displays the article below the form.
Link obtained here is of the type:
/contact-me#modal-jform_consentbox

Before patch, indeed, we do not even get that.

MORE: I needed to enable bootstrap for com_contact for Beez
In that case I do get a modal although the display may be obfuscated if Tabs have been chosen to display the contact.
Works fine with sliders.

Seems to be a z-index issue here:

Updated beez3 CSS for modal rendering in tabs. Hope this doesn't break anything.

@@pmleconte please test > https://docs.joomla.org/Testing_Joomla!_patches

@pmleconte Beez3 has Components Requiring Bootstrap option for loading Bootstrap CSS.

@pmleconte Beez3 has Components Requiring Bootstrap option for loading Bootstrap CSS.

Oops, i did not read Jean Marie's comment.

Maybe, this could be added to privacy suite documentation.

I have tested this item ? unsuccessfully on ee3d22c

Privacy Note is not a clickable.

@jwaisner did you assign a privacy article in Content - Confirm Consent plugin options?

Yes, the article was assigned in the plugin options.

I can't reproduce your issue. Does this happen without patch too?

With PR applied modal popup works for the consent.

Can I recommend removing the "Next" and "Prev" buttons for the privacy article modal? That might cause confusion and seems to let you navigate the site in the modal window if you click next.

With PR applied modal popup works for the consent.

I'm confused. Does it work or not? In your screenshot it looks like you're using Protostar template but this needs to be tested on Beez3.

Can I recommend removing the "Next" and "Prev" buttons for the privacy article modal?

Please open a new issue for this.

I have tested this item ✅ successfully on a507f5e

This works as far as this PR concerned. I will open a ticket for the suggestion.

I have tested this item ✅ successfully on a507f5e

RTC

Thanks