Feeling Lucky
?
[#23202] - Use an editor for custom banner code
- Closed
- 5 Jun 2019
- Medium
- Build: staging
- # 23202
- Diff
- okonomiyaki3000:patch-1
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Custom banner code should be html. It's inhumane to ask people to write it into a textarea. Use Codemirror.
Pull Request for Issue # .
Summary of Changes
Changed field type from textarea to editor, specifically Codemirror.
Testing Instructions
Edit/Create code-type banners.
Expected result
Editing the code should be a lot more comfortable than before. Other than that, no change.
Actual result
As expected
Documentation Changes Required
Nope
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners |
fabpacheco
- comment
- 21 Jan 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23202.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 21 Jan 2019
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23202.
HLeithner
- comment
- 5 Jun 2019
Because this is a new feature please create a new Pull Request for Joomla! 4.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-05 17:00:52 |
| Closed_By | ⇒ | HLeithner |
I have tested this item✅ successfully on 8e02c7a
?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23202.