[#23190] - Re-add generic CSS classes in subforms.
- Fixed in Code Base
- 24 Dec 2018
- Medium
- Build: staging
- # 23190
- Diff
- chrisdavenport:subform-css-issue
User tests: Successful: Unsuccessful:
Summary of Changes
When support for nested subforms was added in #17552 (Joomla 3.9.0) the generic CSS classes group-add, group-remove and group-move were replaced by subform-specific classes which include the subform id. Unfortunately, the absence of the generic classes makes it harder to style these elements, so this PR adds the generic classes back in.
Testing Instructions
Set up a subform so you check the markup. A good example can be found in #17552
In your browser, view source or use dev tools to check that the generic group-add, group-remove and group-move classes are now included as well as the group-add-xx, group-remove-xx and group-move-xx classes (where xx is a subform id).
Expected result
Generic and subform-specific classes should both be available.
Actual result
Only subform-specific classes are available.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23190.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23190.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-12-24 20:44:39 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks guys!
I have tested this item✅ successfully on d1d990f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23190.