Joomla! Issue Tracker | Joomla! CMS #23181 - [4.0] Fatal error with getUpdateQueries()

? Information Required J4 Issue ?

Closed
4 Jan 2020
Medium
Build: master
# 23181

b2z
27 Nov 2018

So I am started to test my component on Joomla 4 ?

After installation I cannot access System section anymore because of the fatal error:
Argument 1 passed to Joomla\CMS\Schema\ChangeSet::getUpdateQueries() must be of the type array, boolean given, called in /var/www/nnt.ncj4/public_html/libraries/src/Schema/ChangeSet.php on line 74

Additionally I have a warning:
JFolder: :files: Path is not a folder. Path: /var/www/nnt.ncj4/public_html/administrator/components/com_competition/sql/updates/mysql

Seems that I need to put my update SQLs under /sql/updates/mysql folder, because currently they are under /sql/updates.

But the question is - should it lead to fatal error and block the access to System section?

b2z - open - 27 Nov 2018

joomla-cms-bot - labeled - 27 Nov 2018

mbabker - comment - 27 Nov 2018

Oh the problems here are interesting...

Just looking at this bit of code tells me:

Core is trying to enforce a file path for SQL files; such a standardization does not exist and it should not be assumed the folder's presence actually means update deltas exist here
When parsing the XML manifest, the first <schemapath> element is used. This should retrieve the path for the correct database driver from the manifest. If whomever fixes this isn't copying the logic from Joomla\CMS\Installer\Installer::parseSchemaUpdates() (since core doesn't actually have a service layer for tasks like finding an extension's SQL schema files) then they're Doing It Wrong™.
There's no check to say "hey, there isn't a directory here, we should abort the task", it's just assumed the directory will always exist.
Likewise, the Joomla\CMS\Schema\ChangeSet class just arbitrarily assumes the folder it's being given actually exists and that the search for files will always return an array (ignoring it can have a boolean return if the filesystem API has an error)

b2z - comment - 27 Nov 2018

Yeap that was working fine on J3.
Mine is looking like this now:

<install>
		<sql>
			<file driver="mysql" charset="utf8">sql/install.mysql.utf8.sql</file>
		</sql>
	</install>
	<uninstall>
		<sql>
			<file driver="mysql" charset="utf8">sql/uninstall.mysql.utf8.sql</file>
		</sql>
	</uninstall>
	<update>
		<schemas>
			<schemapath type="mysql">sql/updates</schemapath>
		</schemas>
	</update>

3 and 4. Well :) There a lot of work should be done ;)

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23181.}