Feeling Lucky
?
?
[#23175] - Fix a few sql errors in Article List on SQL Server
- Fixed in Code Base
- 28 Nov 2018
- Medium
- Build: staging
- # 23175
- Diff
- csthomas:sqlsrv_articles_fix
User tests: Successful: Unsuccessful:
Summary of Changes
There is a few errors in sql query for Sql Server:
- the keyword
KEYis reserved and has to be quoted: https://docs.microsoft.com/en-us/sql/t-sql/language-elements/reserved-keywords-transact-sql?view=sql-server-2017 COUNT(asso2.id)>1 as associationis incorrect. The Sql server does not accept such syntax. I changed it toCASE WHEN COUNT(asso2.id)>1 THEN 1 ELSE 0 END as association- replace the semicolon with a comma in installation file for SQL Server
- fix
JDatabaseQuerySqlsrvmethod to correctly remove theDISTINCTkeyword from column names inGROUP BYstatement.
Testing Instructions
Test the list of articles on MySql on a multilingual website.
Sql Server may still be broken due to an additional error in SQL queries to the the session table.
[Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Implicit conversion from data type nvarchar to varbinary is not allowed. Use the CONVERT function to run this query
Expected result
Article List still works on mysql.
Actual result
Article List on frontend / backend does not work on SQL Server. (multilingual)
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content MS SQL SQL Installation Libraries |
| Labels |
Added:
?
|
||
| Title |
|
||||||
infograf768
- comment
- 28 Nov 2018
I have tested this item
OK here using mysql
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23175.
| Status | Pending | ⇒ | Ready to Commit |
infograf768
- comment
- 28 Nov 2018
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23175.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-11-28 15:06:11 |
| Closed_By | ⇒ | mbabker |
I have tested this item✅ successfully on 00d0017
on code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23175.