[#23153] - Confirm Consent Plugin Rendering Issues
- Fixed in Code Base
- 26 Nov 2018
- Medium
- Build: staging
- # 23153
- Diff
- zero-24:confirmConsent
User tests: Successful: Unsuccessful:
Pull Request for Issue #23069 .
Summary of Changes
As requested #23069 by @mbabker & @SharkyKZ
Testing Instructions
- Install 3.9.0
- enable the
Content - ConfirmConsentPlugin - configure this plugin to point to a article
- open a contact page on the website
- make sure the title is clickable and opens an modal
- apply this patch
- make sure it is still opening a modal this time it should be a bs modal
Expected result
own field
Actual result
Rendering Issues
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
Well i have been told to move it to its own field -> done. If that is not the right solution please suggest the correct solution and i'm happy to apply it ;-)
And please also review the other fields that just output html code inside a field..
You don't echo the modal, assign the result of JHtml::_() to a variable (i.e. $html).
Then have your return concatenate the modal and the layout (i.e. return $html . $this->getRenderer($this->renderLabelLayout)->render(array_merge($data, $extraData));
This field uses modals in this way.
| Labels |
Added:
?
|
||
Patched.
Ok what is the plan here? Patch this in 3.9.1 or move both PRs to 3.9.2?
Well if someone would actually test this...
There's a styling issue with modal header. It's right-aligned because of label. Perhaps modal output should be added to renderField() instead.
@zero-24 see zero-24#40.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23153.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23153.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-11-26 22:02:18 |
| Closed_By | ⇒ | mbabker |
This still outputs the modal when it shouldn't. There can be no
echos in field class.