? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
22 Nov 2018

Summary of Changes

Adding css in Atum template-rtl.scss

Testing Instructions

Test by modifying <rtl tag in en-GB.xml.
No need in this case to use Persian to test.

Use npm ci

Reference

The menu as we get it for LTR
screen shot 2018-11-22 at 17 46 05

Before PR in RTL

screen shot 2018-11-22 at 18 02 36

After PR in RTL

screen shot 2018-11-22 at 17 48 06

@C-Lodder @Quy @wilsonge

avatar infograf768 infograf768 - open - 22 Nov 2018
avatar infograf768 infograf768 - change - 22 Nov 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Nov 2018
Category Administration Templates (admin)
c953965 23 Nov 2018 avatar infograf768 cs
avatar infograf768 infograf768 - change - 23 Nov 2018
Labels Added: ?
avatar richard67
richard67 - comment - 24 Nov 2018

I have tested this item successfully on 1e7874d

Tested with Persian language.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23143.

avatar richard67 richard67 - test_item - 24 Nov 2018 - Tested successfully
avatar infograf768
infograf768 - comment - 25 Nov 2018

Thanks for testing. need one more.

avatar Quy
Quy - comment - 26 Nov 2018

Joomla! Update, Multilingual Associations and Post-Installation Messages don't align with the other menus that have submenus.

ae9163c 26 Nov 2018 avatar infograf768 oops
555a3e3 26 Nov 2018 avatar infograf768 oops2
avatar infograf768
infograf768 - comment - 26 Nov 2018

@Quy @richard67
You are correct. Fine tuned these alignment.
Please test again

We should now get:
screen shot 2018-11-26 at 08 52 34

avatar Quy
Quy - comment - 26 Nov 2018

For the submenus, move to the right slightly.

avatar infograf768
infograf768 - comment - 27 Nov 2018

@Quy
moved 2px to the right

screen shot 2018-11-27 at 07 29 34

avatar infograf768
infograf768 - comment - 27 Nov 2018

Note to @Quy : we can play forever with slight modifications for these margins. The results are somehow a bit different when using Persian, Arabic or Hebrew as my experience shows it may depend on the font used.

avatar Quy
Quy - comment - 27 Nov 2018

I have tested this item successfully on ba1a189


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23143.

avatar Quy
Quy - comment - 27 Nov 2018

I have tested this item successfully on ba1a189


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23143.

avatar Quy Quy - test_item - 27 Nov 2018 - Tested successfully
avatar wilsonge wilsonge - change - 29 Nov 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-11-29 17:42:05
Closed_By wilsonge
avatar wilsonge wilsonge - close - 29 Nov 2018
avatar wilsonge wilsonge - merge - 29 Nov 2018

Add a Comment

Login with GitHub to post a comment