Feeling Lucky
?
?
[#23135] - Fix for Field Group being output when empty
- Fixed in Code Base
- 18 Dec 2018
- Medium
- Build: staging
- # 23135
- Diff
- AndySDH:patch-2
User tests: Successful: Unsuccessful:
Summary of Changes
Currently in Joomla, if a Field Group is empty (there are no values attached to any of the fields included in the field group) the surrounding <dl> tag is still output. Causing unwanted empty spaces.
There already is a check for individual fields not containing values, but there is no check if ALL the fields don't contain values at all.
This fixes the issue.
Testing Instructions
- Create a Field Group
- Assign a Field to this Field Group, and assign it to a Category
- Visit an article included in the assigned Category (without giving a value to the field)
- See that an empty
<dl class="fields-container"></dl>is output. - Apply Patch
- See that the empty
<dl class="fields-container"></dl>is not output anymore.
Expected result
- There should be no ouput when the group is empty.
Actual result
- Surrounding HTML is output even when there is nothing to display.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_fields |
| Labels |
Added:
?
|
||
Quy
- comment
- 22 Nov 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23135.
cheesegrits
- comment
- 12 Dec 2018
I have tested this item
Tested successfully
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23135.
AndySDH
- comment
- 12 Dec 2018
Can this be merged after the successful tests?
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 12 Dec 2018
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23135.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-12-18 02:43:31 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
@Quy & @SharkyKZ can you test?
Thanks for your contributions!