?
avatar wilsonge
wilsonge
21 Nov 2018

Steps to reproduce the issue

Use a custom repeatable field and create an element of type media.

This was mentioned in passing by @AndySDH in #22415 (comment) but wasn't super relevant to that issue so I'm moving it into it's own issue.

To make this work we either need to reload the subform field data out so that we can figure out what the type is and process it in the layout with that meta information. Alternatively we should store it with the field meta information prepended (which would be a b/c break but I'd argue the media field is right now broken as it should behave the same as the existing media field)

Expected result

In the frontend the image is rendered (like the media custom field)

Actual result

The image is not rendered (the path to the image is rendered as a string)

avatar wilsonge wilsonge - open - 21 Nov 2018
avatar joomla-cms-bot joomla-cms-bot - change - 21 Nov 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 21 Nov 2018
avatar AndySDH
AndySDH - comment - 21 Nov 2018

As you might have seen in #22415 that you linked, the repeatable field is getting replaced by the subform field: #22446

And that already fixed this issue and it does render the media field.

That is if progress on that is made faster haha.

Please help with the testing to speed up the process as well :)

avatar franz-wohlkoenig franz-wohlkoenig - change - 4 Mar 2019
Status New Discussion
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 28 Mar 2019

@AndySDH so this Issue can be closed?

avatar franz-wohlkoenig franz-wohlkoenig - change - 28 Mar 2019
Status Discussion Information Required
avatar franz-wohlkoenig franz-wohlkoenig - change - 28 Mar 2019
Category Fields
avatar flyingwombats
flyingwombats - comment - 28 Mar 2019

So there is an issue with repeatable fields.
We cannot get subforms into joomla 3.10 because its a new feature and there are no new features in 3.10
BUT.... could subforms be brought in to 3.10 or even 3.9.6 (3.9.5 is about to be packaged) as a bug fix and not a feature? As its replacing one way of doing something with another and fixes a bug, could it not be argued that its a bug/security fix and not a feature?!?
Just saying

avatar AndySDH
AndySDH - comment - 28 Mar 2019

@AndySDH so this Issue can be closed?

Technically yes... There is no point in fixing this if it's getting deprecated anyway...

But...

So there is an issue with repeatable fields.
We cannot get subforms into joomla 3.10 because its a new feature and there are no new features in 3.10
BUT.... could subforms be brought in to 3.10 or even 3.9.6 (3.9.5 is about to be packaged) as a bug fix and not a feature? As its replacing one way of doing something with another and fixes a bug, could it not be argued that its a bug/security fix and not a feature?!?
Just saying

You're preaching to the choir... I'm with you, I'd love if that was possible, we tried everything to get #22446 pushed in 3.9.x but they just don't want to do it :( I guess because it's a pretty big revamp and not just a small fix.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 29 Mar 2019

@HLeithner can you please decide as Release Lead 3.9?

avatar HLeithner
HLeithner - comment - 29 Mar 2019

@wilsonge do you see any bug fix for this in 3.9, else you should close it because we will have a subfields for j4.

avatar wilsonge
wilsonge - comment - 2 Apr 2019

I mean the things unusable. But it makes more sense to do a migration in j4 for subforms than try and fix stuff here

avatar wilsonge wilsonge - change - 2 Apr 2019
Status Information Required Closed
Closed_Date 0000-00-00 00:00:00 2019-04-02 15:41:30
Closed_By wilsonge
avatar wilsonge wilsonge - close - 2 Apr 2019

Add a Comment

Login with GitHub to post a comment