[#2313] - Use IE=edge by default.
- Closed
- 24 Dec 2013
- Medium
- Build: master
- # 2313
- Diff
- okonomiyaki3000:use_ie_edge_by_default
- Foreign ID 32396
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This patch fixes this issue: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32396&start=0
It's a template issue but, rather than fix it in the template, I'm fixing it in the HTML document class. Why?
1) Easy to override (for testing or whatever) without modifying any Joomla! files.
2) Future template writers need not be concerned with remember the tag.
3) 99.9% of all templates that will ever be created should want to use this setting anyway.
Actually, IE should always use the proper mode if the Doctype is set. You only need to specify this if the doctype is not set properly.
Also, depending on the template it will either break it or double the meta tag if they already use a X-UA-Compatible directive. Keep in mind that templates usually just add meta tags to the index file. There is no reason at all that they use $doc->setMetadata() for this. So no, this is the wrong way to do it.
If you still want to add this directive, please add it to the template(s) instead where it belongs.
However reading the tracker I think the problem is more related to the computer or user and not to the template. There aren't even steps to reproduce the issue. So I'm about uncertain about this.
Personally, I don't agree with @okonomiyaki3000 . If this meta were to to be used, it should be at the template level anyway. This is something that, like the doctype, should be set at the template level.
Setting this meta is far from ideal in even the best of circumstances as it breaks validation and frequently has no effect anyway. A better option would be to set this in the .htaccess per the current html5 boilerplate recommendation: h5bp/html5-boilerplate@5e26749
See also h5bp/html5-boilerplate#378 for related issues. There are many cases where IE will revert to compatibility mode, even when the doctype is correctly set, unfortunately.
I understand the concerns. My first thought was just fix it at the template level too. This is fine but I think we should make sure that all built in templates at least have this in place. In the case of Isis, it's set in the login template but not the index. And so, for some reason, on some PCs, IE uses the wrong mode.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2013-12-24 08:07:09 |
@nternetinspired mind sharing your thoughts on this? Thanks mate!