? ? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
19 Nov 2018

Pull Request for pr #22460.

Summary of Changes

Deprecates when Javascript files are loaded in none defer mode. This is a less disruptive way to migrate the eco system to load JS files in a none blocking way.

Testing Instructions

Open the back end.

Expected result

All is working as expected.

Actual result

All is working as expected.

Documentation Changes Required

Loading JS files in defer mode must be documented.

avatar laoneo laoneo - open - 19 Nov 2018
avatar laoneo laoneo - change - 19 Nov 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Nov 2018
Category Libraries
avatar mbabker
mbabker - comment - 19 Nov 2018

?

I don't think it is our job as a software distributor to force all JavaScript to be loaded in this way. We should support the HTML standard, which includes optionally deferring scripts. We can default the platform to it (accounting for end user concerns), we should not force the platform to only use it.

avatar joeforjoomla
joeforjoomla - comment - 19 Nov 2018

I fully agree with @mbabker here. Loading script in defer mode is an optional HTML attribute and it should be in Joomla as well. IMHO i completely refuse this PR.

avatar laoneo
laoneo - comment - 19 Nov 2018

Or we can just add a deprecate message when the defer attribute is not set?

avatar mbabker
mbabker - comment - 19 Nov 2018

That still creates the impression that Joomla as a platform is stating "the only way we support JavaScript in our API is when it is deferred". Which is a wrong statement to make.

avatar joeforjoomla
joeforjoomla - comment - 19 Nov 2018

Basically i would not do nothing on this matter. I would leave freedom to developers if loading a script in deferred mode or not, hence both methods are perfectly correct. Additionally, in some cases it could be needed to load a script in a non-deferred way to have things working.

avatar laoneo laoneo - change - 19 Nov 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-11-19 19:17:23
Closed_By laoneo
Labels Added: ? ?
avatar laoneo laoneo - close - 19 Nov 2018

Add a Comment

Login with GitHub to post a comment