? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
18 Nov 2018

Summary of Changes

Fix undefined awesomplete , in finder.js

Testing Instructions

Open home page, and check a browser dev console

Expected result

no errors

Actual result

there an error "awesomplete undefined ..."

avatar Fedik Fedik - open - 18 Nov 2018
avatar Fedik Fedik - change - 18 Nov 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Nov 2018
Category Front End com_finder Modules
avatar infograf768
infograf768 - comment - 18 Nov 2018

Adding to Test instructions: create a smartsearch Module in frontend.

avatar infograf768
infograf768 - comment - 18 Nov 2018

I have tested this item successfully on cde45eb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23113.

avatar infograf768 infograf768 - test_item - 18 Nov 2018 - Tested successfully
avatar Quy
Quy - comment - 19 Nov 2018

I have tested this item successfully on cde45eb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23113.

avatar Quy Quy - test_item - 19 Nov 2018 - Tested successfully
avatar Quy Quy - change - 19 Nov 2018
Status Pending Ready to Commit
avatar joomla-cms-bot joomla-cms-bot - edited - 19 Nov 2018
avatar Quy
Quy - comment - 19 Nov 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23113.

avatar laoneo laoneo - change - 19 Nov 2018
Labels Added: ? ?
avatar infograf768
infograf768 - comment - 19 Nov 2018

In fact, the error had changed here to

TypeError: e is not a constructor[Learn More] finder.min.js:1:965
r/<
http://localhost:8888/installmulti/joomla40/media/com_finder/js/finder.min.js:1:965
forEach self-hosted:262:13 r
http://localhost:8888/installmulti/joomla40/media/com_finder/js/finder.min.js:1:899

With what @laoneo added I now have
Using $this when not in object context

avatar infograf768 infograf768 - change - 19 Nov 2018
Status Ready to Commit Pending
Labels
avatar infograf768
infograf768 - comment - 19 Nov 2018

Resetting to pending


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23113.

avatar infograf768
infograf768 - comment - 19 Nov 2018

Resetting to pending


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23113.

avatar laoneo laoneo - change - 19 Nov 2018
Labels Removed: ?
avatar laoneo
laoneo - comment - 19 Nov 2018

Fixes the error in the module. Thanks for testing.

avatar infograf768
infograf768 - comment - 20 Nov 2018

Fixes the error in the module. Thanks for testing.

All good now. Waiting for reply to @wilsonge comment to set test Ok again on Issues.

avatar infograf768
infograf768 - comment - 20 Nov 2018

I have tested this item successfully on cc71f67


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23113.

avatar infograf768
infograf768 - comment - 20 Nov 2018

I have tested this item successfully on cc71f67


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23113.

avatar infograf768 infograf768 - test_item - 20 Nov 2018 - Tested successfully
avatar wilsonge wilsonge - close - 21 Nov 2018
avatar wilsonge wilsonge - merge - 21 Nov 2018
avatar wilsonge wilsonge - change - 21 Nov 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-11-21 00:07:42
Closed_By wilsonge
avatar wilsonge
wilsonge - comment - 21 Nov 2018

Thanks guys. Sorry for holding this one up

Add a Comment

Login with GitHub to post a comment