? Pending

User tests: Successful: Unsuccessful:

avatar anibalsanchez
anibalsanchez
16 Nov 2018

Pull Request for Issue #23038.

Summary of Changes

The issue is caused by a mismatch between the Joomla\CMS\Application\ConsoleApplication call to the parent constructor, and the Joomla\Console\Application.

This fix simply removes the extra parameter of the parent constructor call, to match the parent constructor definition.

Testing Instructions

  1. Create a CLI script. For instance, you can use this script as a sample script Joomla Console.
  2. Read a variable from the general configuration. e.g. offline_message

Expected result

The current value.

Actual result

null

avatar anibalsanchez anibalsanchez - open - 16 Nov 2018
avatar anibalsanchez anibalsanchez - change - 16 Nov 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Nov 2018
Category Libraries
avatar Quy Quy - change - 17 Nov 2018
Title
Fix for parent constructor call mismatch #23038
[4.0] Fix for parent constructor call mismatch #23038
avatar joomla-cms-bot joomla-cms-bot - edited - 17 Nov 2018
avatar wilsonge wilsonge - change - 21 Nov 2018
Labels Added: ?
avatar Hackwar
Hackwar - comment - 7 Jan 2019

I have tested this item successfully on 4ef326e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23100.

avatar Hackwar Hackwar - test_item - 7 Jan 2019 - Tested successfully
avatar wilsonge
wilsonge - comment - 21 Mar 2019

This has been reworked and fixed as part of #23847 - sorry for not dealing with this at the time though!

avatar wilsonge wilsonge - change - 21 Mar 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-03-21 14:13:58
Closed_By wilsonge
avatar wilsonge wilsonge - close - 21 Mar 2019

Add a Comment

Login with GitHub to post a comment