[#23091] - TinyMCE modals (editors-xtd buttons) are responsive
- Fixed in Code Base
- 12 Dec 2018
- Medium
- Build: staging
- # 23091
- Diff
- twister65:modal-xtd
User tests: Successful: Unsuccessful:
Pull Request for Issue #18447 and #20350 .
Summary of Changes
We open a modal window in fullscreen for mobile.
Testing Instructions
Log in as administrator with your smartphone.
Select TinyMCE editor in Global Configuration.
Edit an article.
Click on Module, Contact, Menu, Article, Image, Field, Page Break buttons.
Change the orientation of the screen (landscape, portrait) on smartphones.
Expected result
A modal window is opened and fills the screen.
The modals of the xtd plugins are not cut and can be closed.
Actual result
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
?
|
||
Use
JFactory::getApplication()->client->mobilefor mobile device checks instead of hardcoding a list of platforms.
That's what I did first, but it is not fit with a tablet. That's why I only choose smartphones.
I have tested this item
Patch works on real devices but solution is perfect as it won't work when you simply change the screen size.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23091.
I have tested this item
Patch works on real devices but solution is perfect as it won't work when you simply change the screen size.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23091.
@twister65 there is a cleaner way to do this: the mootools modal already has a resize function and the only changes that needs is:
- on the constructor check if the window width is more than the modal width (then use it else reduce it to something less than the window width, same for the height)
- make sure that resize follows the same pattern
Solving client side problems in PHP is not really a good idea...
Check https://codepen.io/dgrammatiko/pen/JeyyBx?editors=1010
Lines 148 to 160 on the js part
Solving client side problems in PHP is not really a good idea...
I totally agree with you
@dgrammatiko , this is a tinyMCE issue.
#20350 (comment)
It uses its own window manager :
| Title |
|
||||||
@ReLater and @infograf768, please could you test this PR ?
It should fix your issues.
I see a problem with this responsive behavior. Test the Module button with screen width below 769px. Column "Position" is hidden.
I know that's an underlying issue with the modules selection view (CSS classes "hidden-phone" of some columns) but I feel uncertain if I can test successfully then.
@ ReLater, I think it's very difficult to add other columns with such devices.
I propose to remove the CSS classes "hidden-phone" for column "Position" in modal.php view of modules. Maybe in a later pr.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23091.
I have tested this item
Thank you
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23091.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23091.
I have tested this successfully
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23091.
I have tested this successfully
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23091.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-12-12 05:39:29 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Use
JFactory::getApplication()->client->mobilefor mobile device checks instead of hardcoding a list of platforms.