? ? Pending

User tests: Successful: Unsuccessful:

avatar twister65
twister65
15 Nov 2018

Pull Request for Issue #18447 and #20350 .

Summary of Changes

We open a modal window in fullscreen for mobile.

Testing Instructions

Log in as administrator with your smartphone.
Select TinyMCE editor in Global Configuration.
Edit an article.
Click on Module, Contact, Menu, Article, Image, Field, Page Break buttons.
Change the orientation of the screen (landscape, portrait) on smartphones.

Expected result

A modal window is opened and fills the screen.
The modals of the xtd plugins are not cut and can be closed.

Actual result

screenshot_image

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
5.00

avatar twister65 twister65 - open - 15 Nov 2018
avatar twister65 twister65 - change - 15 Nov 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Nov 2018
Category Front End Plugins
avatar twister65 twister65 - change - 15 Nov 2018
Labels Added: ?
avatar mbabker
mbabker - comment - 15 Nov 2018

Use JFactory::getApplication()->client->mobile for mobile device checks instead of hardcoding a list of platforms.

avatar twister65
twister65 - comment - 16 Nov 2018

Use JFactory::getApplication()->client->mobile for mobile device checks instead of hardcoding a list of platforms.

That's what I did first, but it is not fit with a tablet. That's why I only choose smartphones.

avatar brianteeman
brianteeman - comment - 16 Nov 2018

@mbabker is right - we shouldnt be hardcoding it here and should be using the existing api. We wouldnt want to have to update the list in multiple places. (and anyway this hardcoded list is not complete)

avatar ivankomlev
ivankomlev - comment - 16 Nov 2018

I have tested this item successfully on a77176c

Patch works on real devices but solution is perfect as it won't work when you simply change the screen size.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23091.

avatar ivankomlev
ivankomlev - comment - 16 Nov 2018

I have tested this item successfully on a77176c

Patch works on real devices but solution is perfect as it won't work when you simply change the screen size.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23091.

avatar ivankomlev ivankomlev - test_item - 16 Nov 2018 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 17 Nov 2018

@twister65 there is a cleaner way to do this: the mootools modal already has a resize function and the only changes that needs is:

  • on the constructor check if the window width is more than the modal width (then use it else reduce it to something less than the window width, same for the height)
  • make sure that resize follows the same pattern

Solving client side problems in PHP is not really a good idea...

Check https://codepen.io/dgrammatiko/pen/JeyyBx?editors=1010
Lines 148 to 160 on the js part

avatar twister65
twister65 - comment - 17 Nov 2018

Solving client side problems in PHP is not really a good idea...

I totally agree with you

avatar twister65
twister65 - comment - 17 Nov 2018

@dgrammatiko , this is a tinyMCE issue.
#20350 (comment)
It uses its own window manager :

$tempConstructor[] = 'editor.windowManager.open(modalOptions);';

avatar twister65 twister65 - change - 18 Nov 2018
Title
TinyMCE modals (editors-xtd plugins) are suitable for a smartphone.
TinyMCE modals (editors-xtd buttons) are responsive
avatar twister65 twister65 - edited - 18 Nov 2018
avatar twister65 twister65 - change - 18 Nov 2018
The description was changed
avatar twister65 twister65 - edited - 18 Nov 2018
avatar twister65
twister65 - comment - 18 Nov 2018

@ReLater and @infograf768, please could you test this PR ?
It should fix your issues.

avatar ReLater
ReLater - comment - 18 Nov 2018

I see a problem with this responsive behavior. Test the Module button with screen width below 769px. Column "Position" is hidden.

I know that's an underlying issue with the modules selection view (CSS classes "hidden-phone" of some columns) but I feel uncertain if I can test successfully then.

avatar twister65 twister65 - change - 18 Nov 2018
The description was changed
avatar twister65 twister65 - edited - 18 Nov 2018
avatar twister65
twister65 - comment - 30 Nov 2018

Module modal screenshot with a mobile:
screenshot_module
@ReLater, I think it's very difficult to add other columns with such devices.

avatar twister65 twister65 - change - 30 Nov 2018
The description was changed
avatar twister65 twister65 - edited - 30 Nov 2018
avatar ReLater
ReLater - comment - 9 Dec 2018

@ ReLater, I think it's very difficult to add other columns with such devices.

I propose to remove the CSS classes "hidden-phone" for column "Position" in modal.php view of modules. Maybe in a later pr.

09-12-_2018_21-54-14

avatar ReLater
ReLater - comment - 9 Dec 2018

I have tested this item successfully on a2523bb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23091.

avatar ReLater ReLater - test_item - 9 Dec 2018 - Tested successfully
avatar Milglius
Milglius - comment - 10 Dec 2018

I have tested this item successfully on a2523bb

Thank you


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23091.

avatar Milglius Milglius - test_item - 10 Dec 2018 - Tested successfully
avatar Quy Quy - change - 10 Dec 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 10 Dec 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23091.

avatar Milglius
Milglius - comment - 10 Dec 2018

I have tested this successfully


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23091.

avatar Milglius
Milglius - comment - 10 Dec 2018

I have tested this successfully


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23091.

avatar mbabker mbabker - change - 12 Dec 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-12-12 05:39:29
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 12 Dec 2018
avatar mbabker mbabker - merge - 12 Dec 2018

Add a Comment

Login with GitHub to post a comment