? Success

User tests: Successful: Unsuccessful:

avatar eddieajau
eddieajau
22 Oct 2013

This PR removes the class alias file for the DI package from the framework. It is far better to teach developers the right way to deal with namespacing from day-one as this will open more opportunities for more of the Framework or other PSR-0 compatible code to be included in the CMS.

avatar eddieajau eddieajau - open - 22 Oct 2013
avatar dongilbert
dongilbert - comment - 22 Oct 2013

I would tend to agree with you. And since there hasn't been a CMS release with these classes in place, it is vital that if we are going to remove them, we do it sooner rather than later.

avatar eddieajau
eddieajau - comment - 22 Oct 2013

Ok. Since this is just correcting a new feature anyway, can we just merge it or do I need to double handle it in JoomlaCode?

avatar dbhurley
dbhurley - comment - 22 Oct 2013

Based on the fact that this is affecting new code committed only in this same beta phase, this is considered an update to that submitted code and not regarded as a bug or new feature but rather an update to an existing, accepted and merged PR.

avatar dbhurley dbhurley - reference | - 22 Oct 13
avatar dbhurley dbhurley - merge - 22 Oct 2013
avatar dbhurley dbhurley - close - 22 Oct 2013
avatar garyamort garyamort - reference | - 2 Dec 13

Add a Comment

Login with GitHub to post a comment