[#23082] - Change the URL to the PHP Date Function
- Fixed in Code Base
- 17 Nov 2018
- Medium
- Build: staging
- # 23082
- Diff
- imanickam:patch-9
User tests: Successful: Unsuccessful:
Current:
http://www.php.net/manual/en/function.date.php - this URL does not work; it requires signing into the php.net site
Proposed:
http://php.net/date - this URL works and is consistent with other language strings MOD_ARTICLES_CATEGORY_FIELD_DATEFIELDFORMAT_DESC and MOD_ARTICLES_CATEGORY_FIELD_MONTHYEARFORMAT_DESC
Pull Request for Issue # .
Summary of Changes
Current language string:
JGLOBAL_DATE_FORMAT_DESC="Optional format string for showing the date. For example, D M Y for day month year or you can use d-m-y for a short version eg. 28-12-16. See http://www.php.net/manual/en/function.date.php. If left blank, it uses DATE_FORMAT_LC1 from your language file."
Revised language string:
JGLOBAL_DATE_FORMAT_DESC="Optional format string for showing the date. For example, D M Y for day month year or you can use d-m-y for a short version eg. 28-12-16. See http://php.net/date. If left blank, it uses DATE_FORMAT_LC1 from your language file."
Testing Instructions
(a) Go to the screen "Articles: Options" (Content => Articles > Options)
(b) Click on the tab List Layouts
(c) For the option "Show Date", choose the value Created or Modified or Published)
(d) Move the cursor over the label "Date Format" - Review the pop-up help text
(e) Type the URL shown in the pop-up help text in a separate window/tab of a browser and see what happens
Expected result
(a) Pop-up Help Text
(b) URL to the PHP Date Function taken from the pop-up Help Text
Actual result
(a) Pop-up Help Text
(b) URL to the PHP Date Function taken from the pop-up Help Text
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
I have tested this item
If this may help some users, let's change it.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23082.
yes I agree, I think the redirect also handles the language param in the url right as well - another reason to change it.
Just being picky but can we use https://secure.php.net/date instead of http://php.net/date ?
also might be good to remove all these https://github.com/joomla/joomla-cms/search?q=php.net%2Fmanual%2Fen&unscoped_q=php.net%2Fmanual%2Fen as well?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23082.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23082.
This is clearly an upstream problem with the mirror that you are being directed to. Have you reported it upstream so it can be fixed for everyone that uses php
This is clearly an upstream problem with the mirror that you are being directed to. Have you reported it upstream so it can be fixed for everyone that uses php
Yes, the problem has been reported - Bug #77161 - PHP.net Website Problem (https://bugs.php.net/bug.php?id=77161).
Might be worth telling the PHP guys where you are in the world, and maybe your IP because then they might be able to "guess" which mirror you get redirected to.
Might be worth telling the PHP guys where you are in the world, and maybe your IP because then they might be able to "guess" which mirror you get redirected to.
Good Idea. I thought that the IP address would be stored along with the bug report when you create one, just like we can find out from which IP address the post has been created in the Joomla! Forum.
| Labels |
Added:
?
|
||
| Labels |
Added:
?
?
|
||
Standardized the URL that references the date function in PHP from http://php.net/date to https://php.net/date.
This has been changed in the file en-GB.mod_articles_category.ini (that is located in the directory \language\en-GB) as well.
The URLs are changed in the language strings MOD_ARTICLES_CATEGORY_FIELD_DATEFIELDFORMAT_DESC and MOD_ARTICLES_CATEGORY_FIELD_MONTHYEARFORMAT_DESC
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-11-17 17:24:48 |
| Closed_By | ⇒ | mbabker |
http://php.net/manual/en/function.date.php works fine for me here without authentication. Im guessing you are seeing a mirror site once bounced? Personally I like the shorter url that you propose as its normally quicker to type ;-)