Sorry did't noticed this on the PR before :( Where this needs to be moved too?

Paging @SharkyKZ as they're the one who raised the issue, I just pulled it here to not get lost in a merged PR.

This would normally be in field's getLabel() function or field layout. But this plugin uses core field, does some HTML and adds it to the form XML. So not sure where to put it. Probably need to create a custom field type like in other plugins.

Unless someone's going to commit to fixing this in the next day or two I'm reverting the original PR before 3.9.1 ships.

You cannot have markup render in the onContentPrepareForm event. The event is triggered on requests that result in a redirect, and outputting random things can potentially cause issues.

Unless someone's going to commit to fixing this in the next day or two I'm reverting the original PR before 3.9.1 ships.

Unless someone can tell me how to fix it i can not fix it so please revert if you feel so.

You can’t render the modal inside the onContentPrepareForm method. I think
it was suggested you’d need a custom FormField subclass for this, that
would work.

On Fri, Nov 23, 2018 at 9:19 AM zero-24 notifications@github.com wrote:

Unless someone's going to commit to fixing this in the next day or two I'm
reverting the original PR before 3.9.1 ships.

Unless someone can tell me how to fix it i can not fix it so please revert
if you feel so.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#23069 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfobcnBvccb4fhUddq1H41HA1kdPwwks5uyBIQgaJpZM4Yci-f
.

--

• Michael Please pardon any errors, this message was sent from my iPhone.

Please checkout: #23153