?
avatar PhilETaylor
PhilETaylor
13 Nov 2018

Paging @mbabker to fix the travis PHP 7.3 build please :):)

...........................SS.../home/travis/.travis/job_stages: line 104:  2551 Illegal instruction     (core dumped) libraries/vendor/bin/phpunit --configuration travisci-phpunit.xml
The command "if [[ $RUN_UNIT_TESTS == "yes" ]]; then libraries/vendor/bin/phpunit --configuration travisci-phpunit.xml; fi" exited with 132.

https://travis-ci.org/joomla/joomla-cms/jobs/454185931

avatar PhilETaylor PhilETaylor - open - 13 Nov 2018
avatar joomla-cms-bot joomla-cms-bot - change - 13 Nov 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 13 Nov 2018
avatar PhilETaylor PhilETaylor - change - 13 Nov 2018
The description was changed
avatar PhilETaylor PhilETaylor - edited - 13 Nov 2018
avatar zero-24
zero-24 - comment - 13 Nov 2018

it seams like to be and problem at travis itself? As the file that throws the error is /home/travis/.travis/job_stages: line 104: ?

avatar mbabker
mbabker - comment - 13 Nov 2018

It's either an issue with the Travis platform or with the PHP 7.3 RC itself. Laravel too has the same problem.

avatar PhilETaylor
PhilETaylor - comment - 13 Nov 2018

Well apparently the solution is to ignore it... e5157f2

avatar PhilETaylor PhilETaylor - change - 13 Nov 2018
Status New Closed
Closed_Date 0000-00-00 00:00:00 2018-11-13 22:00:29
Closed_By PhilETaylor
avatar PhilETaylor PhilETaylor - close - 13 Nov 2018
avatar zero-24 zero-24 - change - 13 Nov 2018
Status Closed New
Closed_Date 2018-11-13 22:00:29
Closed_By PhilETaylor
avatar zero-24
zero-24 - comment - 13 Nov 2018

Solution is not the right term but as this is something out of the control of our code and seams to be a problem on other repos too we should give travis time to take a look but not blocking all PRs to be merged when Travis fails.

avatar zero-24 zero-24 - reopen - 13 Nov 2018
avatar PhilETaylor
PhilETaylor - comment - 13 Nov 2018

screenshot 2018-11-13 at 22 32 46
screenshot 2018-11-13 at 22 33 50

The test suite runs perfectly, and completes, on my mac with PHP 7.3beta3.

avatar zero-24
zero-24 - comment - 13 Nov 2018

Yes it seams that travis now uses RC5 and as said before the error message looks like a travis platform issue not a PHP issue itself lets check what happens at the time RC6 comes out.

avatar PhilETaylor
PhilETaylor - comment - 13 Nov 2018

With PHP 7.3RC5 in a docker container I get:

screenshot 2018-11-13 at 22 36 48

and that comes from this test

Starting test 'JComponentRouterRulesNomenuTest::testConstruct'.

avatar zero-24
zero-24 - comment - 13 Nov 2018

undefined index SCRIPT_NAME ? Can you identify the failing test? Can you confirm that docker container runs the tests successful on an other PHP Version? (just to make sure anything required is running there)

avatar PhilETaylor
PhilETaylor - comment - 13 Nov 2018

failing test was

Starting test 'JComponentRouterRulesNomenuTest::testConstruct'.

I removed that, next failure with the same error is

Starting test 'JHelpTest::testCreateUrl'.
EUndefined index: SCRIPT_NAME

removed that test and then

Starting test 'JHtmlIconsTest::testButtons'.
EUndefined index: SCRIPT_NAME

removed that test and then

Starting test 'JLayoutFileTest::testEscape'.
EUndefined index: SCRIPT_NAME

avatar mbabker
mbabker - comment - 13 Nov 2018

Congrats, Phil. You've just run into the same issues what tests we have left have always had. There's global state bleedover between tests and they aren't portable across environments.

====

Yes it seams that travis now uses RC5 and as said before the error message looks like a travis platform issue not a PHP issue itself lets check what happens at the time RC6 comes out.

There's no assurance that it is not a PHP issue. Just because the file path has what is presumably the file that the YAML config is parsed into does not automatically mean it is a Travis-CI issue. FWIW I did get a project to run its test suite on Travis-CI with PHP 7.3 RC 5 so that does give some credit to it not being a platform (whatever the system the Travis-CI run is being made on) problem and some credit toward a potential PHP bug (and considering both Joomla's and Laravel's test suites are having the same issue, that does seem to strengthen that argument).

avatar PhilETaylor
PhilETaylor - comment - 13 Nov 2018

Congrats, Phil. You've just run into the same issues what tests we have left have always had. There's global state bleedover between tests and they aren't portable across environments.

This project never ceases to amaze me. The one whole point of tests is that they are runable and portable... /facepalm

After faking SCRIPT_NAME in TestCase.php setUp function (and directly in a load of tests) I was able to run the complete test suite on PHP 7.3RC5. in a docker container (Alpine based, PHP Earth packages - same build that ALL the LIVE myJoomla.com service containers are running in production)

avatar PhilETaylor
PhilETaylor - comment - 13 Nov 2018

As a core file is generated, is there any interest in looking at something like http://jsteemann.github.io/blog/2014/10/30/getting-core-dumps-of-failed-travisci-builds/ ?

avatar PhilETaylor
PhilETaylor - comment - 14 Nov 2018

very very strange :)

avatar PhilETaylor PhilETaylor - change - 14 Nov 2018
Status New Closed
Closed_Date 0000-00-00 00:00:00 2018-11-14 04:28:38
Closed_By PhilETaylor
avatar PhilETaylor PhilETaylor - close - 14 Nov 2018

Add a Comment

Login with GitHub to post a comment