? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
12 Nov 2018

Removed duplicated meaning comment

pretty obvious :)

avatar PhilETaylor PhilETaylor - open - 12 Nov 2018
avatar PhilETaylor PhilETaylor - change - 12 Nov 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Nov 2018
Category Front End com_contact
avatar Quy
Quy - comment - 12 Nov 2018

I have tested this item successfully on 33bedad


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23049.

avatar Quy Quy - test_item - 12 Nov 2018 - Tested successfully
avatar SharkyKZ
SharkyKZ - comment - 12 Nov 2018

I have tested this item successfully on 33bedad


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23049.

avatar SharkyKZ
SharkyKZ - comment - 12 Nov 2018

I have tested this item successfully on 33bedad


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23049.

avatar SharkyKZ SharkyKZ - test_item - 12 Nov 2018 - Tested successfully
avatar Quy Quy - change - 12 Nov 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 12 Nov 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23049.

avatar Quy
Quy - comment - 12 Nov 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23049.

avatar wilsonge wilsonge - change - 12 Nov 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-11-12 20:33:07
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 12 Nov 2018
avatar wilsonge wilsonge - merge - 12 Nov 2018
avatar zero-24
zero-24 - comment - 13 Nov 2018

@wilsonge why did you tag this as 4.0 when it got merged into 3.10? Why at all was this be send against 3.10-dev and not against staging? @PhilETaylor

avatar PhilETaylor
PhilETaylor - comment - 13 Nov 2018

No idea - I was pretty sure everything was made against staging.

I'm kind confused what staging actually contains, as there is a 3.10 and 4.0 branch too - so always stick to staging or the 4.0-dev branch.

Is there a document that helps developers understand what branches are being used for what purpose?

avatar rdeutz
rdeutz - comment - 13 Nov 2018

Always use staging for 3.x stuff, 3.10 is the bridge to 4. Release lead will merge staging in 3.10 when needed. If you do work for 4 the use 4.0-dev

avatar PhilETaylor
PhilETaylor - comment - 13 Nov 2018

well as 3.10 is over 200 commits behind staging, and 4.0-dev is over 5440 commits behind... someone has a lot of work to do!

avatar rdeutz
rdeutz - comment - 13 Nov 2018

not your problem

avatar mbabker
mbabker - comment - 13 Nov 2018

Are you sure you're not looking at your fork? There's no way in hell there have been 200 commits since 3.9.0 release, when I last branch merged to 3.10.

screen shot 2018-11-13 at 3 44 57 pm

https://github.com/joomla/joomla-cms/branches

avatar PhilETaylor
PhilETaylor - comment - 13 Nov 2018

not your problem

What a bad attitude to have. Its all our problem. Its strange that so few people are actually working on Joomla development, so few ...

@mbabker Im just reporting what I see, and no, this is not my fork:

see: http://screenshot.myjoom.la/672d79e251bf

EDIT: Actually - Im wrong, thats the AHEAD commits, its the other number - much lower 27 :)

avatar mbabker
mbabker - comment - 13 Nov 2018

Well, your image link is broken, but...

The left side of that bar is commits behind the default branch (staging), right side is commits ahead (and there's a tooltip explaining that). So 3.10 is 27 commits behind and 202 ahead staging.

avatar rdeutz
rdeutz - comment - 13 Nov 2018

To point with your finger that someone has a lot of work to do, wasn't a better attitude. Look at yourself before you criticise others

avatar PhilETaylor
PhilETaylor - comment - 13 Nov 2018

Wow... simply pathetic attitude. And you wonder why people dont contribute to Joomla...

avatar zero-24
zero-24 - comment - 13 Nov 2018

Is there a document that helps developers understand what branches are being used for what purpose?

Yes and GitHub shows you that all the time you do a PR, even when it is a bit hidden now days ;)

https://github.com/joomla/joomla-cms/blob/staging/.github/CONTRIBUTING.md

Add a Comment

Login with GitHub to post a comment