[#23047] - [4.0] System Panel: Add badges to items when necessary
- Fixed in Code Base
- 21 Nov 2018
- Medium
- Build: 4.0-dev
- # 23047
- Diff
- infograf768:4-0_addbadges
User tests: Successful: Unsuccessful:
Pull Request for Issue #23032
Summary of Changes
As title says.
Testing Instructions
- Checkout some items.
- Modify your php.ini: for example set
file_uploads = Offto get a Warning - Modify
administrator/manifests/files/joomla.xml
to
<version>4.0.0-alpha4</version>
andlibraries/src/Version.php
toconst EXTRA_VERSION = 'alpha4-dev';
in order to get a database fix issue - Add a module or plugin to be discovered.
- Install an older language pack in order to get a warning for an update.
fr-FR_joomla_lang_full_3.9.0v1.zip
Note: Although we should get also a pill for a joomla update with this patch, I did not find a way to test that.
EDIT: see #23047 (comment) to test joomlaupdate
After patch
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_cpanel |
| Labels |
Added:
?
|
||
This is why it MUST be implemented with an ajax call, like on the control panel. Else the user could be sitting there waiting ages for the page to load.
Improvements are welcome. Me not know how to make the js/ajax as done for quickicon.
Phil, is the number of updates stored in the session? If so, surely we can use that instead.
EDIT:
To test JoomlaUpdate
as you already did
Modify administrator/manifests/files/joomla.xml
to
4.0.0-alpha4
and libraries/src/Version.php
to const EXTRA_VERSION = 'alpha4-dev';
in order to get a database fix issue
Just fix database.
Then in JoomlaUpdate Options choose Custom URL and add this link (Thanks Tobias) :
https://update.joomla.org/core/nightlies/next_major_list.xml
Then you can look again at the System CPanel
There will be a pill
NOTE TO MYSELF for another PR, once #22985 has been merged:
Correct joomalupdate js file to use
updateInfo.version instead of updateInfoList.length
This will give for quickicons
instead of a zero
All modifications now done.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23047.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23047.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks for help in code simplification and testing
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23047.
RTC. Thanks for help in code simplification and testing
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23047.
NOTE: after this merge, I will make a second PR to adapt this to RTL languages.
| Labels |
Added:
?
|
||
@Quy @richard67
Please test again.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-11-21 15:58:22 |
| Closed_By | ⇒ | wilsonge |
Merging as we had two good tests and I code reviewed the small change to the way models are loaded
Doing a check fo updates in the main thread will mean that this page can take a LONG time to open depending on the number of extensions to check and the speed of the update sites.
This is why it MUST be implemented with an ajax call, like on the control panel. Else the user could be sitting there waiting ages for the page to load.