[#23044] - [3.9] Remove factually incorrect sentence
- Fixed in Code Base
- 12 Nov 2018
- Medium
- Build: staging
- # 23044
- Diff
- PhilETaylor:actionlogscanbedeleted
User tests: Successful: Unsuccessful:
Summary of Changes
Remove factually incorrect sentence - Closes #22873
Testing Instructions
install Joomla 4 and edit the Privacy - Action Logs plugin
Expected result
Factually correct information - the action logs CAN be deleted (purged in total, or row by row)
Actual result
"Since the action logs are an audit log, these can not be deleted from the system"
Documentation Changes Required
Probably...
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23044.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23044.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-11-12 23:58:45 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
?
?
|
||
I totally agree with changing the attitude of the statement in the language string.
However, as of now, the language string values for the same constant are not the same in the following files.
(a) File: plg_system_actionlogs.ini
PLG_SYSTEM_ACTIONLOGS_XML_DESCRIPTION="Record the actions of users on the site so they can be reviewed if required."
(b) File: plg_system_actionlogs.sys.ini
PLG_SYSTEM_ACTIONLOGS_XML_DESCRIPTION="To record actions of users within the CMS."
My suggestion:
(i) Make the language string values for the language constant PLG_SYSTEM_ACTIONLOGS_XML_DESCRIPTION the same (ie. in both the files).
(ii) Probably the language string value could be changed as follows or in line with the suggestion.
PLG_SYSTEM_ACTIONLOGS_XML_DESCRIPTION="Records the actions of users on the site so they can be reviewed if required."
Agree with you on this one @imanickam can you create a pull request for this string changes, please?
The reason this was just one small change is that it was done in the Github interface and thus only one file can be edited and Pr'ed at a time - Ive never found a way to do more than one file that way
The reason this was just one small change is that it was done in the Github interface and thus only one file can be edited and Pr'ed at a time - Ive never found a way to do more than one file that way
Just go to your fork and add new commits to the auto generated branch ;) So for this patch it would haven been: https://github.com/PhilETaylor/joomla-cms/tree/actionlogscanbedeleted and there you can add new changes / commits that come up to your PR until the branch is merged ;)
quite frankly after tonights abuse - I'll pass. I have more important things to work on.
This PR is already merged. If people dont like it, they are free to make a new PR - making sure they get the right branch of course, would hate for someone to make a single minor mistake out of over 20 PRs....
But cool tip - thanks.
This PR is already merged. If people dont like it, they are free to make a new PR
Yes this is the reason i suggested exactly that a few comments above. Just wanted to explain your question. :)
I have tested this item✅ successfully on 7a5e2fd
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23044.