? Pending

User tests: Successful: Unsuccessful:

avatar csthomas
csthomas
11 Nov 2018

Pull Request for Issue #22983

Summary of Changes

Reverted a few lines added in the previous PR #19467
Changed the unit test method JPaginationTest::buildLink($url) to better emulate Router::build($url), where empty parameters such as &limitstart= are always removed from the URL.

Testing Instructions

Test #22983 when SEF is ON and OFF.

Expected result

You can back to the first page in pagination when SEF is OFF.

Actual result

When SEF is OFF the limitstart parameter remains in the link to the first page and you can not back to the first page.

Documentation Changes Required

No

avatar csthomas csthomas - open - 11 Nov 2018
avatar csthomas csthomas - change - 11 Nov 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Nov 2018
Category Libraries Unit Tests
avatar hendrikbehncke
hendrikbehncke - comment - 12 Nov 2018

Test successful on 3f30b88


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23042.

avatar hendrikbehncke
hendrikbehncke - comment - 12 Nov 2018

Test successful on 3f30b88


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23042.

avatar Quy
Quy - comment - 13 Nov 2018

I have tested this item successfully on 3f30b88


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23042.

avatar Quy Quy - test_item - 13 Nov 2018 - Tested successfully
avatar Quy Quy - change - 13 Nov 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 13 Nov 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23042.

avatar mbabker mbabker - change - 17 Nov 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-11-17 17:28:45
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 17 Nov 2018
avatar mbabker mbabker - merge - 17 Nov 2018

Add a Comment

Login with GitHub to post a comment