Feeling Lucky
?
[#23042] - [3.9] Fix navigating to the first page in pagination when SEF is off
- Fixed in Code Base
- 17 Nov 2018
- Medium
- Build: staging
- # 23042
- Diff
- csthomas:fix_nonsef_limitstart
User tests: Successful: Unsuccessful:
Pull Request for Issue #22983
Summary of Changes
Reverted a few lines added in the previous PR #19467
Changed the unit test method JPaginationTest::buildLink($url) to better emulate Router::build($url), where empty parameters such as &limitstart= are always removed from the URL.
Testing Instructions
Test #22983 when SEF is ON and OFF.
Expected result
You can back to the first page in pagination when SEF is OFF.
Actual result
When SEF is OFF the limitstart parameter remains in the link to the first page and you can not back to the first page.
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries Unit Tests |
hendrikbehncke
- comment
- 12 Nov 2018
Test successful on 3f30b88
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23042.
Quy
- comment
- 13 Nov 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23042.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 13 Nov 2018
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23042.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-11-17 17:28:45 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Test successful on 3f30b88
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23042.