Feeling Lucky
?
?
[#23026] - [4.0] getReorderConditions() cleanup
- Fixed in Code Base
- 11 Nov 2018
- Medium
- Build: 4.0-dev
- # 23026
- Diff
- SharkyKZ:getReorderConditions
User tests: Successful: Unsuccessful:
Pull Request for Issue #23021.
Summary of Changes
Always return an array.
Switch to short array syntax.
Escape column names.
Don't escape integers.
Fix typo in comment.
Testing Instructions
Code review.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_categories com_contact com_content com_fields com_menus com_modules com_newsfeeds com_plugins com_workflow Libraries |
| Labels |
Added:
?
|
||
richard67
- comment
- 10 Nov 2018
I have tested this item
Code review.
Drone build failure not related to this PR.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23026.
Quy
- comment
- 10 Nov 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23026.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 10 Nov 2018
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23026.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-11-11 23:52:07 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 11 Nov 2018
Thanks!
I have tested this item✅ successfully on 5fa8d11
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23026.