Pull Request for Issue # N.A.

Summary of Changes

This pull request (PR) cleans up the Cassiopeia template and SQL scripts for installation of core and sample data from unused copy-and-paste remainders coming from Joomla 3 by doing 3 things:

1. Remove unused module class (formerly called module class suffix) "_menu" from menu modules.
2. Remove unused menu class (formerly called menu class suffix) "nav-pills" from menu modules and contact links.
3. Remove handling of not existing parameter "templateColor" from offline page of Cassiopeia template.

These three changes are separated to three commits, so maintainers can cherry-pick some of the changes if not all three are accepted.

Where do these changes apply:

1. The module class "_menu" is added to the default "Main Menu" on new installation of J4, to diverse menus in testing sample data and to the language-specific main menus in multilanguage sample data, but it has no effect on styling, and when creating a new menu, it is not added, which is an inconsistency between the pre-defined menus mentioned before and a newly created menu.
2. The menu class "nav-pills" is added in blog sample data for menus at module position "top-a", e.g. the "Main Menu Blog", but it has no effect, i.e. Bootstrap nav-pills does not work in Cassiopeia in general. It is also added to the contact links but has also no effect, and finally it is used in the handling of the not existing parameter "templateColor" in the offline.php of the cassiopesia template.
3. The offline.php of the cassiopesia template adds CSS if the parameter "templateColor" was set in the template style's advanced options of that template, but that template does not have any parameter like this.

Testing Instructions

Experienced maintainers or reviewers:

Code review should be enough.

Normal testers:

Install new J4 (e.g. alpha 5 or a later nightly build) with blog sample data.

1. Verify in advanced options of menu modules that in some case module class "_menu" is present, and in some other cases menu class "nav-pills" is present.
2. Check the menus with menu class "nav-pills" on the site (frontend) and verify that the menus do not look like Bootstrap's "nav-pills" but look like all other menus, which are vertical menus.
   Create a contact with contact links and a menu item for that contact.
   Check the contact page on the site (frontend): The links do not look like Bootstrap's "nav-pills" but look like vertical menus. Make a screenshot of the contact page.
3. Check that nowhere in the options of the Cassiopeia template is any option for template colors. Set the site offline and make a screenshot of the offline page.

Now unpack the install package which you have used, apply the changes from this PR, pack it again and make a new installation with that modified package.

Or use the modified nightly build from today available here: (obsolete link removed)

Install blog sample data. Create a contact and a menu item for it in the same way as before with the unmodified installation. Check with this new installation that:

1. Menus which had module class "_menu" with the unmodified installation now do not have this menu class, and they look the same as before with the unmodified new installation.
2. Menus which had menu class "nav-pills" with the unmodified installation now do not have this menu class, and they look the same as before with the unmodified new installation. Verify that the contact page looks the same as before with the unmodified installation.
3. Set the site offline. Verify that the offline page looks the same as before with the unmodified installation.

Expected result

None of the menu modules coming with a new installation or any kind of sample data contains any module class "_menu" or menu class "nav-pills", which is consistent with a newly created menu module.

The default_links.php template of com_contacts does not add class "nav-pills" to the links list, which would have no visual effect.

The Cassiopeia template's offline page does not handle a not existing option about template colors, which clearly was a remainder from copying stuff from J3's Protostar template.

Actual result

The opposite of the expected result.

Some examples on the incisistency of menu module css classes:

1. Module "Main Menu" after a new installation:
   

2. A newly created menu module:
   

3. Module "Main Menu Blog" after blog sample data installation:
   

Documentation Changes Required

No idea. Check if menu class "nav-pills" and module class "_menu" are referred somewhere in J4 docs.