? ?
avatar PhilETaylor
PhilETaylor
9 Nov 2018

s/succesfully/successfully

avatar PhilETaylor PhilETaylor - open - 9 Nov 2018
avatar SharkyKZ
SharkyKZ - comment - 10 Nov 2018

This issue does not appear on the Issue Tracker for some reason.

avatar richard67 richard67 - change - 10 Nov 2018
Build staging 4.0-dev
avatar richard67
richard67 - comment - 10 Nov 2018

@PhilETaylor I've corrected the build for you (staging -> 4.0-dev).


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23008.

avatar richard67
richard67 - comment - 10 Nov 2018

It appears on the tracker but has no option to test it.

I've tested it with success. Code review + check that this PR covers all occurrences of wrong English "succesfully" (case-insensitive) in Joomla 4.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23008.

avatar PhilETaylor
PhilETaylor - comment - 10 Nov 2018

@PhilETaylor I've corrected the build for you (staging -> 4.0-dev).

Doh. I gave up a long time ago correcting spelling in 3.x :)

avatar richard67
richard67 - comment - 10 Nov 2018

Does anybody have an idea why for this PR there is no button for testing shown in the issue tracker?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23008.

avatar PhilETaylor
PhilETaylor - comment - 10 Nov 2018

Maybe @mbabker might know - else you will have to view the source code of the tracker.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23008.

avatar mbabker
mbabker - comment - 10 Nov 2018

Webhook doesn't process correctly the most likely cause.

avatar richard67
richard67 - comment - 10 Nov 2018

@SharkyKZ Have you tested this PR with success and just could not report that on the issue tracker because of problems mentioned above? If yes, then report it back here so @Quy could make it RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23008.

avatar Twincarb
Twincarb - comment - 10 Nov 2018

Code Review
No Test Button to confirm as above comments


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23008.

avatar Quy
Quy - comment - 10 Nov 2018

Does PR #14607 apply here with comments?

avatar PhilETaylor
PhilETaylor - comment - 10 Nov 2018

No - it doesn’t apply in the slightest

——
Sent from my iPhone - sorry - if needed I’ll send longer email from my desk later.
——

On 10 Nov 2018, at 16:26, Quy notifications@github.com wrote:

Does PR #14607 apply here with comments?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

avatar Quy Quy - change - 10 Nov 2018
Status New Ready to Commit
avatar Quy
Quy - comment - 10 Nov 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23008.

avatar Quy Quy - change - 12 Nov 2018
Title
s/succesfully/successfully
[4.0] s/succesfully/successfully
avatar joomla-cms-bot joomla-cms-bot - edited - 12 Nov 2018
avatar joomla-cms-bot joomla-cms-bot - change - 12 Nov 2018
Category Front End Plugins
avatar laoneo laoneo - change - 13 Nov 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-11-13 18:29:38
Closed_By laoneo
Labels Added: ? ?
avatar laoneo laoneo - close - 13 Nov 2018
avatar laoneo laoneo - merge - 13 Nov 2018
avatar richard67
richard67 - comment - 13 Nov 2018

succesfully merged ;-)

Add a Comment

Login with GitHub to post a comment