Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
30 Nov 2011

This pull request implements JGrid in some backend components.

This touches the users view of com_users and the categories view of com_categories. These changes are 100% backwards compatible and will not influence existing templates. For future templates, it will be easier to modify the existing views and less code will be necessary for this.

This reduces the amount of code necessary for generating the backend tables and simplifies the hathor overrides.

If the platform project accepts a change to JView, the tables could also be modified by a plugin, maybe removing the need for overrides in quite a few cases.

avatar Hackwar Hackwar - open - 30 Nov 2011
avatar infograf768
infograf768 - comment - 30 Nov 2011

Please post your patch in the tracker. This is where we test and comment for now.

avatar dextercowley
dextercowley - comment - 30 Nov 2011

Hannes, I don't see an issue for this in the Feature Tracker on Jcode. Can
you please add one there so people can test and comment? Thanks. Mark

On Wed, Nov 30, 2011 at 3:22 AM, Hannes Papenberg <
reply@reply.github.com

wrote:

This pull request implements JGrid in some backend components.

This touches the users view of com_users and the categories view of
com_categories. These changes are 100% backwards compatible and will not
influence existing templates. For future templates, it will be easier to
modify the existing views and less code will be necessary for this.

This reduces the amount of code necessary for generating the backend
tables and simplifies the hathor overrides.

If the platform project accepts a change to JView, the tables could also
be modified by a plugin, maybe removing the need for overrides in quite a
few cases.

You can merge this Pull Request by running:

git pull https://github.com/Hackwar/joomla-cms jgrid

Or you can view, comment on it, or merge it online at:

#23

-- Commit Summary --

  • Implementing JGrid in com_users users view and com_categories categories view

-- File Changes --

M
administrator/components/com_categories/views/categories/tmpl/default.php
(109)
M administrator/components/com_categories/views/categories/view.html.php
(101)
M administrator/components/com_users/views/users/tmpl/default.php (117)
M administrator/components/com_users/views/users/tmpl/modal.php (41)
M administrator/components/com_users/views/users/view.html.php (149)
M
administrator/templates/hathor/html/com_categories/categories/default.php
(111)
M administrator/templates/hathor/html/com_users/users/default.php (125)
M administrator/templates/hathor/html/com_users/users/modal.php (49)

-- Patch Links --

https://github.com/joomla/joomla-cms/pull/23.patch
https://github.com/joomla/joomla-cms/pull/23.diff


Reply to this email directly or view it on GitHub:
#23

avatar elinw elinw - reference | - 11 Dec 11
avatar phproberto phproberto - close - 3 Oct 2013
avatar phproberto
phproberto - comment - 3 Oct 2013

I'm closing this as it's not mergeable and 2 years old. Feel free to open if you update it and are still interested in get it merged.

Thanks for contributing.

avatar wilsonge wilsonge - reference | 86ffbec - 12 Jun 14
avatar Hackwar Hackwar - head_ref_deleted - 10 Dec 2014
avatar infograf768 infograf768 - reference | 21822ad - 6 Jan 15
avatar N6REJ N6REJ - reference | 5d2682e - 6 Jan 15
avatar rdeutz rdeutz - reference | 9474532 - 1 Oct 15

Add a Comment

Login with GitHub to post a comment