?
avatar PhilETaylor
PhilETaylor
9 Nov 2018

Steps to reproduce the issue

Install Joomla 4.0-dev
Login to admin and navigate to the Joomla update component

Expected result

Normally you will see at least one warning in my experience, they are in an accordion.

I expect that the display will look good, making clear what I see are the headers of an accordion that can be clicked, and clear when they are clicked. The first item in the accordion is closed in 4.0 and open in 3.x

Actual result

Everything is flat on a white background and doesn't give any indication they can be clicked.

screen recording 2018-11-09 at 07 56 pm

(compared to Joomla 3.9.0 below)

screenshot 2018-11-09 at 19 57 28

avatar PhilETaylor PhilETaylor - open - 9 Nov 2018
avatar joomla-cms-bot joomla-cms-bot - change - 9 Nov 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 9 Nov 2018
avatar infograf768
infograf768 - comment - 10 Nov 2018

My experience here (as I had to cope with this in com_localise), is that we miss a css:
when we use HTMLHelper::_('bootstrap.addSlide' we get the class class="card-header for the slide and class="accordion" for the <div>.
therefore we do need for example:

.accordion .card-header {
    background-color: #cfe6e9;
    something
    something else
}
avatar mbabker
mbabker - comment - 10 Nov 2018

No, the use of Bootstrap elements needs to be corrected. I don't know who decided to misuse the Card component's header class in incompatible contexts but that needs to be corrected, not furthered upon (if it's not wrapped in <div class="card"> then none of Bootstrap's card-* classes should be used, I'm looking at you module chromes...).

avatar C-Lodder
C-Lodder - comment - 11 Nov 2018

@mbabker I dont see any misuse of the card component here. It's purely a styling related component and has no JS associated with it, nor do the classes affect a11y.

It's simply due to the fact the background has been set to transparent:

https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/templates/atum/scss/_variables.scss#L139

avatar mbabker
mbabker - comment - 11 Nov 2018

Well then things have changed because there was a point where .card-header was being used with modules with no sort of wrapping .card anywhere. And to me that is misuse, even if it is "purely a styling related component".

avatar C-Lodder
C-Lodder - comment - 11 Nov 2018

Ahh in that aspect

avatar PhilETaylor PhilETaylor - change - 10 Feb 2019
Status New Closed
Closed_Date 0000-00-00 00:00:00 2019-02-10 21:33:03
Closed_By PhilETaylor
avatar PhilETaylor PhilETaylor - close - 10 Feb 2019

Add a Comment

Login with GitHub to post a comment