? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
9 Nov 2018

Pull Request for a partial fix to Issue #22949 .

Summary of Changes

cast to int for postgresql

Testing Instructions

see #22949

avatar alikon alikon - open - 9 Nov 2018
avatar alikon alikon - change - 9 Nov 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Nov 2018
Category Libraries
avatar twister65
twister65 - comment - 9 Nov 2018

It fixes plugin update issue.
Very strange, the changes are in ModuleAdapter.
The module update issue is still there.

avatar twister65
twister65 - comment - 9 Nov 2018

Please, replace $db->quote by $db->quoteName

->where($db->quote('client_id') . ' = ' . (int) $this->extension->client_id);

->where($db->quoteName('client_id') . ' = ' . (int) $this->extension->client_id);

avatar mbabker
mbabker - comment - 9 Nov 2018

@twister65 That should really be a separate pull request instead of lumped in with another unrelated change.

avatar twister65
twister65 - comment - 10 Nov 2018

See (test) PR #22993 please.

3617699 10 Nov 2018 avatar Quy done
avatar alikon alikon - change - 10 Nov 2018
Labels Added: ?
avatar csthomas
csthomas - comment - 3 Dec 2018

I have tested this item successfully on 3617699

Code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22984.

avatar csthomas csthomas - test_item - 3 Dec 2018 - Tested successfully
avatar Quy
Quy - comment - 3 Dec 2018

I have tested this item successfully on 3617699


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22984.

avatar Quy Quy - change - 3 Dec 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 3 Dec 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22984.

avatar joomla-cms-bot joomla-cms-bot - edited - 3 Dec 2018
avatar Quy Quy - test_item - 3 Dec 2018 - Tested successfully
avatar mbabker mbabker - change - 5 Dec 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-12-05 00:34:27
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 5 Dec 2018
avatar mbabker mbabker - merge - 5 Dec 2018

Add a Comment

Login with GitHub to post a comment