? Success

User tests: Successful: Unsuccessful:

avatar elinw
elinw
20 Oct 2013
avatar elinw elinw - open - 20 Oct 2013
avatar zero-24
zero-24 - comment - 20 Oct 2013

@test
works here :) xampp 1.7.3 (PHP 5.3.1)

avatar elinw elinw - close - 20 Oct 2013
avatar beat
beat - comment - 20 Oct 2013

I added a few code-review comments here: e646a83

Where is the bug-tracker item for this ?

avatar beat
beat - comment - 20 Oct 2013

BTW: How can same person write and commit the same security-relevant code-change without a tracker item ?

avatar sybrek
sybrek - comment - 20 Oct 2013

+1 beat

avatar beat
beat - comment - 21 Oct 2013

A conversation started there e646a83#commitcomment-4379107

avatar zero-24
zero-24 - comment - 21 Oct 2013

@beat

Where is the bug-tracker item for this ?
BTW: How can same person write and commit the same security-relevant code-change without a tracker item ?

Here is the Tracker Itm:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_id=8103&tracker_item_id=32327

avatar beat
beat - comment - 21 Oct 2013

Thanks @zero-24 for the URL. I also replied to the line comment on the applied patch for future improvments.

avatar garyamort garyamort - reference | - 2 Dec 13

Add a Comment

Login with GitHub to post a comment