J4 Issue ?
avatar PhilETaylor
PhilETaylor
8 Nov 2018

Steps to reproduce the issue

Attempt to install Joomla 4 from 4.0-dev branch
make a typo in the db password

Expected result

A sensible error message

Actual result

A message that tells me the connector returned a number, and then a string instead of a number
screenshot 2018-11-08 at 05 16 23

Could not connect to the database. Connector returned number: Could not connect to database.

avatar PhilETaylor PhilETaylor - open - 8 Nov 2018
avatar joomla-cms-bot joomla-cms-bot - change - 8 Nov 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 8 Nov 2018
avatar PhilETaylor PhilETaylor - change - 8 Nov 2018
The description was changed
avatar PhilETaylor PhilETaylor - edited - 8 Nov 2018
avatar brianteeman brianteeman - change - 8 Nov 2018
Labels Added: J4 Issue
avatar brianteeman brianteeman - labeled - 8 Nov 2018
avatar hardik-codes
hardik-codes - comment - 2 Feb 2019

What should be the correct error message then @PhilETaylor

avatar PhilETaylor
PhilETaylor - comment - 2 Feb 2019

I thought that would be obvious.

As I said: "A message that tells me the connector returned a number, and then a string instead of a number"

So either you should tell me the "returned number" from mysql or you should tell me a sentence and remove the string that says you are telling me the "connector returned number"

avatar hardik-codes
hardik-codes - comment - 2 Feb 2019

In my humble opinion the number is irrelevant for the user. So we can change the error message directly. Is that Ok with you @PhilETaylor

avatar PhilETaylor
PhilETaylor - comment - 2 Feb 2019

Not up to me which way it goes. But whatever it changes to it should make sense.

However the error number can be important as its more specific than "cannot connect"

avatar hardik-codes
hardik-codes - comment - 2 Feb 2019

Could you possibly tell me why this is not working Could not connect to the database. Connector returned number: %s" in /installation/language/en-GB/en-GB.ini and in similar files.
Why does %s not works here??

avatar joomla-cms-bot joomla-cms-bot - edited - 3 Feb 2019
avatar joomla-cms-bot joomla-cms-bot - change - 3 Feb 2019
Closed_Date 2019-02-03 22:25:31 2019-02-03 22:25:32
Closed_By Quy joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 3 Feb 2019
avatar Quy Quy - change - 3 Feb 2019
Status New Closed
Closed_Date 0000-00-00 00:00:00 2019-02-03 22:25:31
Closed_By Quy
avatar joomla-cms-bot
joomla-cms-bot - comment - 3 Feb 2019

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/22961

avatar Quy
Quy - comment - 3 Feb 2019

Please test PR #23759


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22961.

Add a Comment

Login with GitHub to post a comment